Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance: Remove director-v0 client from webserver #4461

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 5, 2023

What do these changes do?

  • completely removes director-v0 from webserver as this shall not be directly used ever
  • removes related tests

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Jul 5, 2023
@sanderegg sanderegg added this to the Watermelon milestone Jul 5, 2023
@sanderegg sanderegg self-assigned this Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #4461 (9570796) into master (cf1c90c) will decrease coverage by 0.6%.
The diff coverage is 60.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4461      +/-   ##
=========================================
- Coverage    85.3%   84.7%    -0.6%     
=========================================
  Files        1011     395     -616     
  Lines       43188   20776   -22412     
  Branches     1016     173     -843     
=========================================
- Hits        36846   17612   -19234     
+ Misses       6108    3115    -2993     
+ Partials      234      49     -185     
Flag Coverage Δ
integrationtests 68.1% <40.0%> (+6.9%) ⬆️
unittests 86.7% <60.0%> (+2.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/application.py 97.9% <ø> (-0.1%) ⬇️
.../simcore_service_webserver/application_settings.py 98.2% <ø> (-0.1%) ⬇️
...re_service_webserver/application_settings_utils.py 97.8% <ø> (-0.2%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 82.3% <60.0%> (-0.2%) ⬇️

... and 701 files with indirect coverage changes

@sanderegg sanderegg marked this pull request as ready for review July 5, 2023 21:23
@codeclimate
Copy link

codeclimate bot commented Jul 5, 2023

Code Climate has analyzed commit 9570796 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀 it served us well! thx for this cleanup!

@sanderegg sanderegg merged commit bef80bb into ITISFoundation:master Jul 6, 2023
@sanderegg sanderegg deleted the maintenance/remove-director-from-webserver branch July 6, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants