Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Update public api system tests #4444

Conversation

bisgaard-itis
Copy link
Contributor

What do these changes do?

Allow the public api systemt tests to download the osparc python client from the Github artifacts on https://github.com/ITISFoundation/osparc-simcore-clients so that the tests on the ci uses the current master client.

Related issue/s

#4345

How to test

DevOps Checklist

@bisgaard-itis bisgaard-itis self-assigned this Jun 30, 2023
@bisgaard-itis bisgaard-itis added the t:maintenance Some planned maintenance work label Jun 30, 2023
@bisgaard-itis bisgaard-itis added this to the Watermelon milestone Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #4444 (154bdc4) into master (67cda11) will decrease coverage by 16.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4444      +/-   ##
=========================================
- Coverage    83.3%   66.6%   -16.8%     
=========================================
  Files         431     395      -36     
  Lines       22545   20788    -1757     
  Branches      173     173              
=========================================
- Hits        18786   13847    -4939     
- Misses       3710    6892    +3182     
  Partials       49      49              
Flag Coverage Δ
integrationtests 66.6% <ø> (-0.1%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 226 files with indirect coverage changes

tests/public-api/conftest.py Outdated Show resolved Hide resolved
services/api-server/Makefile Outdated Show resolved Hide resolved
.github/workflows/ci-testing-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/ci-testing-deploy.yml Outdated Show resolved Hide resolved
tests/public-api/Makefile Outdated Show resolved Hide resolved
tests/public-api/Makefile Outdated Show resolved Hide resolved
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my latest comment. I am happy to discuss offline sometime tomorrow morning

@bisgaard-itis bisgaard-itis requested a review from pcrespov July 6, 2023 11:00
scripts/gh.bash Outdated Show resolved Hide resolved
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 6, 2023 12:10
@codeclimate
Copy link

codeclimate bot commented Jul 6, 2023

Code Climate has analyzed commit 154bdc4 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bisgaard-itis bisgaard-itis merged commit 1026cdd into ITISFoundation:master Jul 6, 2023
@bisgaard-itis bisgaard-itis deleted the update-public-api-system-tests branch October 25, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants