♻️ `webserver`: fixes mypy issues in `session` plugin #4304

pcrespov · 2023-06-02T13:00:36Z

What do these changes do?

♻️ refactors session plugin in webserver
- plugin under session folder
- protected internal modules and defined interface
- renamed _logger
- reviewed TODO annotations
- fixes mypy issues

Related issue/s

part of Maintenance: make mypy pass in all services/packages in repo #4071

How to test

cd services/web/server
make mypy | grep session
pytest -vv tests/**/test_*session*.py

codecov · 2023-06-02T13:25:04Z

Codecov Report

Merging #4304 (8828e3d) into master (11f0fbd) will decrease coverage by 1.1%.
The diff coverage is 97.0%.

@@            Coverage Diff            @@
##           master   #4304      +/-   ##
=========================================
- Coverage    85.5%   84.4%    -1.1%     
=========================================
  Files         965     393     -572     
  Lines       41139   20406   -20733     
  Branches      978     173     -805     
=========================================
- Hits        35188   17242   -17946     
+ Misses       5729    3115    -2614     
+ Partials      222      49     -173

Flag	Coverage Δ
integrationtests	`67.9% <79.4%> (+0.1%)`	⬆️
unittests	`86.1% <94.1%> (+3.1%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/simcore_service_webserver/login/_registration.py	`77.5% <75.0%> (ø)`
...erver/src/simcore_service_webserver/application.py	`97.9% <100.0%> (ø)`
.../simcore_service_webserver/application_settings.py	`98.7% <100.0%> (ø)`
...mcore_service_webserver/garbage_collector_utils.py	`84.8% <100.0%> (ø)`
...rc/simcore_service_webserver/login/handlers_2fa.py	`85.0% <100.0%> (ø)`
...c/simcore_service_webserver/login/handlers_auth.py	`94.2% <100.0%> (ø)`
...e_service_webserver/login/handlers_confirmation.py	`90.5% <100.0%> (ø)`
...e_service_webserver/login/handlers_registration.py	`90.9% <100.0%> (ø)`
...rc/simcore_service_webserver/scicrunch/settings.py	`100.0% <100.0%> (ø)`
...mcore_service_webserver/session/access_policies.py	`94.2% <100.0%> (ø)`
... and 2 more