Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in projects plugin (1 part) #4256

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented May 22, 2023

What do these changes do?

  • ♻️ refactors projects plugin in webserver
    • refactor folders
    • protected internal modules
    • first part of mypy fixes

In the second part:

  • additional mypy fixes
  • review code smells

Related issue/s

How to test

cd services/web/server
make mypy | grep projects

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 22, 2023
@matusdrobuliak66 matusdrobuliak66 added t:maintenance Some planned maintenance work a:webserver issue related to the webserver service labels May 22, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Pastel de Nata milestone May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #4256 (4a3d1f6) into master (ac6cba1) will decrease coverage by 0.2%.
The diff coverage is 96.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4256     +/-   ##
========================================
- Coverage    83.8%   83.7%   -0.2%     
========================================
  Files         924     957     +33     
  Lines       39866   41549   +1683     
  Branches      963     963             
========================================
+ Hits        33427   34793   +1366     
- Misses       6218    6535    +317     
  Partials      221     221             
Flag Coverage Δ
integrationtests 69.0% <86.2%> (-9.4%) ⬇️
unittests 81.9% <96.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core_service_webserver/projects/_handlers_nodes.py 58.8% <ø> (ø)
...imcore_service_webserver/projects/_rest_schemas.py 100.0% <ø> (ø)
...c/simcore_service_webserver/projects/exceptions.py 94.1% <ø> (ø)
...r/src/simcore_service_webserver/projects/models.py 100.0% <ø> (ø)
...src/simcore_service_webserver/projects/settings.py 100.0% <ø> (ø)
...ver/notifications/_db_comp_tasks_listening_task.py 87.0% <33.3%> (+6.0%) ⬆️
.../simcore_service_webserver/application_settings.py 98.7% <100.0%> (ø)
...vice_webserver/exporter/formatters/formatter_v1.py 83.6% <100.0%> (+55.5%) ⬆️
...vice_webserver/exporter/formatters/formatter_v2.py 90.3% <100.0%> (+59.1%) ⬆️
...ore_service_webserver/exporter/request_handlers.py 96.0% <100.0%> (+54.6%) ⬆️
... and 32 more

... and 117 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 22, 2023 09:16
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm 21 code smells?

@matusdrobuliak66
Copy link
Contributor Author

hmmm 21 code smells?

These are things that were already there, just they get noticed now as I am moving a lot of files. As you can see it is already a huge PR just with the moving of the files. Therefore I would like to focus on the code smells and mypy issues incrementally in the following PR.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 22, 2023 13:18
@codeclimate
Copy link

codeclimate bot commented May 24, 2023

Code Climate has analyzed commit 4a3d1f6 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit 549bc81 into ITISFoundation:master May 24, 2023
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ webserver: fixes mypy issues in products plugin (1 part) ♻️ webserver: fixes mypy issues in projects plugin (1 part) Jun 7, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 14, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants