-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ webserver
: fixes mypy issues in projects
plugin (1 part)
#4256
♻️ webserver
: fixes mypy issues in projects
plugin (1 part)
#4256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4256 +/- ##
========================================
- Coverage 83.8% 83.7% -0.2%
========================================
Files 924 957 +33
Lines 39866 41549 +1683
Branches 963 963
========================================
+ Hits 33427 34793 +1366
- Misses 6218 6535 +317
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm 21 code smells?
These are things that were already there, just they get noticed now as I am moving a lot of files. As you can see it is already a huge PR just with the moving of the files. Therefore I would like to focus on the code smells and mypy issues incrementally in the following PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…iltering/sorting/searching I will exlude it for now
…sdrobuliak66/osparc-simcore into maintenance/mypy-webserver-projects
Code Climate has analyzed commit 4a3d1f6 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
webserver
: fixes mypy issues in products
plugin (1 part)webserver
: fixes mypy issues in projects
plugin (1 part)
What do these changes do?
projects
plugin in webserverIn the second part:
Related issue/s
How to test
DevOps Checklist