Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in publications plugin #4238

Merged

Conversation

pcrespov
Copy link
Member

What do these changes do?

  • ♻️ refactors publications plugin in webserver
    • plugin under publications folder
    • protected internal modules and defined interface
    • renamed _logger
    • reviewed TODO annotations

Related issue/s

How to test

cd services/web/server
make mypy | grep publications
pytest -vv tests/**/test_*publications*.py

@pcrespov pcrespov self-assigned this May 15, 2023
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels May 15, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone May 15, 2023
@pcrespov pcrespov marked this pull request as ready for review May 15, 2023 17:58
@pcrespov pcrespov requested review from sanderegg and GitHK as code owners May 15, 2023 17:58
@pcrespov pcrespov requested a review from matusdrobuliak66 May 15, 2023 17:58
@codeclimate
Copy link

codeclimate bot commented May 15, 2023

Code Climate has analyzed commit 8e9e924 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #4238 (8e9e924) into master (0b34859) will increase coverage by 3.4%.
The diff coverage is 85.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4238     +/-   ##
========================================
+ Coverage    82.6%   86.0%   +3.4%     
========================================
  Files         868     798     -70     
  Lines       38483   35699   -2784     
  Branches      583     545     -38     
========================================
- Hits        31808   30732   -1076     
+ Misses       6539    4837   -1702     
+ Partials      136     130      -6     
Flag Coverage Δ
integrationtests 68.7% <77.2%> (+15.3%) ⬆️
unittests 82.3% <85.1%> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imcore_service_webserver/publications/_handlers.py 33.3% <66.6%> (ø)
...rvice-library/src/servicelib/mimetype_constants.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
.../src/simcore_service_webserver/login/_constants.py 100.0% <100.0%> (ø)
...c/simcore_service_webserver/publications/plugin.py 100.0% <100.0%> (ø)

... and 331 files with indirect coverage changes

@pcrespov pcrespov enabled auto-merge (squash) May 15, 2023 18:56
@pcrespov pcrespov merged commit fed9486 into ITISFoundation:master May 16, 2023
@pcrespov pcrespov deleted the is4071/mypy-webserver-publication branch May 16, 2023 09:09
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants