Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in users plugin #4230

Merged
merged 27 commits into from
May 15, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 11, 2023

What do these changes do?

  • ♻️ refactors users plugin in webserver
    • plugin under users folder
    • protected internal modules and defined interface
    • renamed _logger
    • reviewed TODO annotations
    • fixed sqlalchemy deprecation warnings

Related issue/s

How to test

cd services/web/server
make mypy | grep users
pytest -vv tests/**/test_*user*.py

@pcrespov pcrespov force-pushed the is4071/mypy-webserver-users branch from 7d6caeb to 14a5d54 Compare May 11, 2023 18:03
@pcrespov pcrespov self-assigned this May 11, 2023
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label May 11, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #4230 (6d46115) into master (72a09f4) will decrease coverage by 0.9%.
The diff coverage is 97.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4230      +/-   ##
=========================================
- Coverage    85.9%   85.0%    -0.9%     
=========================================
  Files         830     375     -455     
  Lines       36305   19383   -16922     
  Branches      583       0     -583     
=========================================
- Hits        31186   16493   -14693     
+ Misses       4983    2890    -2093     
+ Partials      136       0     -136     
Flag Coverage Δ
integrationtests 68.0% <66.1%> (-0.5%) ⬇️
unittests 84.0% <90.5%> (+1.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ver/src/simcore_service_webserver/groups/plugin.py 100.0% <ø> (ø)
.../simcore_service_webserver/users/_notifications.py 100.0% <ø> (ø)
...imcore_service_webserver/garbage_collector_core.py 82.5% <80.0%> (-0.6%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 84.8% <80.0%> (+1.2%) ⬆️
...ver/src/simcore_service_webserver/users/_tokens.py 95.0% <95.0%> (ø)
...r/src/simcore_service_webserver/users/_handlers.py 96.6% <97.1%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
...vice_webserver/exporter/formatters/formatter_v1.py 83.6% <100.0%> (ø)
...ore_service_webserver/exporter/request_handlers.py 96.0% <100.0%> (ø)
...service_webserver/garbage_collector_tasks_users.py 83.6% <100.0%> (ø)
... and 19 more

... and 519 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4071/mypy-webserver-users branch from 14a5d54 to 94edd0a Compare May 12, 2023 17:45
@pcrespov pcrespov marked this pull request as ready for review May 12, 2023 19:18
@pcrespov pcrespov requested review from sanderegg and GitHK as code owners May 12, 2023 19:18
@pcrespov pcrespov requested a review from matusdrobuliak66 May 12, 2023 19:18
@pcrespov pcrespov enabled auto-merge (squash) May 12, 2023 19:23
@codeclimate
Copy link

codeclimate bot commented May 15, 2023

Code Climate has analyzed commit 6d46115 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big one, thanks!

@pcrespov pcrespov merged commit 0b34859 into ITISFoundation:master May 15, 2023
@pcrespov pcrespov deleted the is4071/mypy-webserver-users branch May 15, 2023 13:50
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants