Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Volumes keep track of their data's state #4228

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 11, 2023

What do these changes do?

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #4228 (b8c6d93) into master (d9fd2da) will decrease coverage by 7.9%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4228      +/-   ##
=========================================
- Coverage    85.4%   77.5%    -7.9%     
=========================================
  Files         940     108     -832     
  Lines       41064    3015   -38049     
  Branches      953       0     -953     
=========================================
- Hits        35081    2339   -32742     
+ Misses       5766     676    -5090     
+ Partials      217       0     -217     
Flag Coverage Δ
integrationtests ?
unittests 77.5% <100.0%> (-5.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/agent/src/simcore_service_agent/core/settings.py 94.2% <100.0%> (+0.1%) ⬆️

... and 836 files with indirect coverage changes

@pcrespov pcrespov added this to the Pastel de Nata milestone May 11, 2023
@GitHK
Copy link
Contributor Author

GitHK commented May 12, 2023

This will definitely now work.
When the user service starts and runs chown, files which are immutable are not ignored and fails to boot. See below output from Jupyter-math.

Folder mounted owned by user 8004:134-''...
Creating new group myjovyan
Adding group `myjovyan' (GID 134) ...
Done.
adding jovyan to group myjovyan...
Chainging owner ship of state directory /home/jovyan/work/workspace
chown: changing ownership of '/home/jovyan/work/workspace/.agent': Operation not permitted
chown: changing ownership of '/home/jovyan/work/workspace/.hidden_do_not_remove': Operation not permitted

A different solution is required

@codeclimate
Copy link

codeclimate bot commented May 12, 2023

Code Climate has analyzed commit c32b134 and detected 0 issues on this pull request.

View more on Code Climate.

@GitHK GitHK closed this May 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants