-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Frontend: Dynamic input ports #4210
✨Frontend: Dynamic input ports #4210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
I have some questions
- this feature was only for file ports, right?
- If so, how ports are shown if a service has its ports mixed: e.g. int, file, float, file, bool, file, file, file, bool.
minVisibleInputs
is a new attribute in the service input. Can you like the PR to the change in the backend?- this value is set at the service metadata, right? i.e. for the example above you released a new version of plot2D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very cool!
A have a similar question to PC's one: does minVisibleInputs
have to be in the service metadata? Does is work like boot-options
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this one is merged I will have a followup PR for the backend to add support for this.
services/static-webserver/client/source/class/osparc/data/model/Node.js
Outdated
Show resolved
Hide resolved
…arc-simcore into feature/dynamic-input-ports
Code Climate has analyzed commit 592e519 and detected 0 issues on this pull request. View more on Code Climate. |
Correct, as mentioned in the PR description
I'm expecting the "dynamic" data inputs to go last in the inputs list
Already answered by @GitHK 👌 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Yes it is needed. |
What do these changes do?
This PR implements a feature that will give users the impression of having dynamic number of inputs (only when it comes to data inputs).
In order to have this feature enabled, the service needs to provide
minVisibleInputs
info. From here on, the frontend and user will play with the number of visibible of the inputs. When instantiating a service, the minVisibleInputs will be shown, then the user can press the plus button to show more, the plus button will disappear when we reach the maximum number of inputs. Also if the last input gets populated, one more will automatically show up.Demo with
minVisibleInputs
=2:Related issue/s
related to ITISFoundation/osparc-issues#419
How to test
DevOps Checklist