Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in products plugin #4145

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • fixes mypy issues in products plugin

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Apr 22, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Apr 22, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Jelly Beans milestone Apr 22, 2023
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #4145 (522b68f) into master (9c6e0c6) will decrease coverage by 7.9%.
The diff coverage is 94.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4145      +/-   ##
=========================================
- Coverage    84.1%   76.2%    -7.9%     
=========================================
  Files         955     399     -556     
  Lines       41361   20605   -20756     
  Branches      945     173     -772     
=========================================
- Hits        34792   15712   -19080     
+ Misses       6365    4844    -1521     
+ Partials      204      49     -155     
Flag Coverage Δ
integrationtests 62.2% <83.7%> (-4.5%) ⬇️
unittests 80.7% <94.1%> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/src/simcore_service_webserver/groups_handlers.py 80.9% <33.3%> (-0.1%) ⬇️
...rver/src/simcore_service_webserver/products/_db.py 76.6% <75.0%> (ø)
...r/src/simcore_service_webserver/products/plugin.py 73.5% <94.4%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
...er/src/simcore_service_webserver/email_handlers.py 91.4% <100.0%> (ø)
...web/server/src/simcore_service_webserver/groups.py 100.0% <100.0%> (ø)
...rc/simcore_service_webserver/login/handlers_2fa.py 85.0% <100.0%> (ø)
...c/simcore_service_webserver/login/handlers_auth.py 94.2% <100.0%> (ø)
...simcore_service_webserver/login/handlers_change.py 88.2% <100.0%> (ø)
...e_service_webserver/login/handlers_confirmation.py 90.5% <100.0%> (ø)
... and 18 more

... and 665 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review April 23, 2023 17:16
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) April 24, 2023 12:40
@codeclimate
Copy link

codeclimate bot commented Apr 24, 2023

Code Climate has analyzed commit 522b68f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants