♻️Clusters: make non dev feature, disabled by default (⚠️) #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusdrobuliak66
approved these changes
Apr 17, 2023
15 tasks
Codecov Report
@@ Coverage Diff @@
## master #4129 +/- ##
=========================================
- Coverage 84.6% 78.0% -6.6%
=========================================
Files 953 398 -555
Lines 41364 20612 -20752
Branches 957 174 -783
=========================================
- Hits 35018 16096 -18922
+ Misses 6128 4467 -1661
+ Partials 218 49 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
force-pushed
the
dask/make_cluster_non_dev
branch
from
af84968 to
2e9440d
Compare
pcrespov
approved these changes
Apr 17, 2023
pcrespov
reviewed
Apr 17, 2023
sanderegg
force-pushed
the
dask/make_cluster_non_dev
branch
2 times, most recently
from
4801868 to
eaf827f
Compare
GitHK
approved these changes
Apr 18, 2023
sanderegg
force-pushed
the
dask/make_cluster_non_dev
branch
from
eaf827f to
bf5a4f2
Compare
|
Code Climate has analyzed commit bf5a4f2 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Apr 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Since the WEBSERVER_DEV_ENABLED env seems to bring some issues, this PR brings
WEBSERVER_CLUTERSout of it.By default it is disabled, and must be explicitly enabled.
Related issue/s
How to test
DevOps Checklist