♻️ SonarCloud issues in director-v2 and dynamic-sidecar
#4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2023 08:19
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
=========================================
- Coverage 83.8% 73.6% -10.3%
=========================================
Files 953 436 -517
Lines 41379 22783 -18596
Branches 957 174 -783
=========================================
- Hits 34716 16777 -17939
+ Misses 6445 5957 -488
+ Partials 218 49 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
approved these changes
Apr 17, 2023
...-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/settings.py
Show resolved
Hide resolved
GitHK
changed the title
director-v2 and dynamic-sidecardirector-v2 and dynamic-sidecar
GitHK
changed the title
director-v2 and dynamic-sidecardirector-v2 and dynamic-sidecar
pcrespov
approved these changes
Apr 17, 2023
...-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/settings.py
Show resolved
Hide resolved
…simcore-forked into pr-osparc-sonar-dy-sidecar
|
Code Climate has analyzed commit c46df5d and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Apr 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Minor complains from SonarCloud started failing. This address them.
Related issue/s
How to test
DevOps Checklist