-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨♻️ Fixes mypy issue after upgrade #4118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4118 +/- ##
========================================
- Coverage 86.7% 85.4% -1.3%
========================================
Files 799 818 +19
Lines 37362 36729 -633
Branches 879 449 -430
========================================
- Hits 32396 31382 -1014
- Misses 4763 5239 +476
+ Partials 203 108 -95
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks.
...simcore_postgres_database/migration/versions/53e095260441_add_projects_access_rights_and_.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/jobs.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_aiosqlalchemy.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/meta.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
...atabase/src/simcore_postgres_database/migration/versions/da8abd0d8e42_add_comp_runs_table.py
Show resolved
Hide resolved
- sqlachemy-stub was not sufficient
d8075a7
to
3645811
Compare
Code Climate has analyzed commit 3645811 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
After the upgrade of
mypy
in PR #4108 I noticed that many of the packages started to fail themypy
type-check step.mypy
configsqlalchemy-stub
does not seem sufficient to supportmypy
. Extended tosqlalchemy[mypy]
. See details here.api-server
catalog
postgres-database
scripts/mypy
changesRelated issue/s
How to test
typecheck
steps in CI passmake mypy