Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨♻️ Fixes mypy issue after upgrade #4118

Merged
merged 12 commits into from
Apr 17, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 16, 2023

What do these changes do?

After the upgrade of mypy in PR #4108 I noticed that many of the packages started to fail the mypy type-check step.

  • 🔨 constraint requirements in mypy config
    • sqlalchemy-stub does not seem sufficient to support mypy. Extended to sqlalchemy[mypy]. See details here.
  • fix new mypy issues in api-server
  • fix new mypy issues in catalog
  • fix new mypy issues in postgres-database
  • 🔨 change CI to trigger all packages with type-check step when scripts/mypy changes

Related issue/s

How to test

  • all typecheck steps in CI pass
  • locally: make mypy

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Apr 16, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 16, 2023
@pcrespov pcrespov self-assigned this Apr 16, 2023
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #4118 (3645811) into master (87322e1) will decrease coverage by 1.3%.
The diff coverage is 85.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4118     +/-   ##
========================================
- Coverage    86.7%   85.4%   -1.3%     
========================================
  Files         799     818     +19     
  Lines       37362   36729    -633     
  Branches      879     449    -430     
========================================
- Hits        32396   31382   -1014     
- Misses       4763    5239    +476     
+ Partials      203     108     -95     
Flag Coverage Δ
integrationtests 52.3% <ø> (-14.4%) ⬇️
unittests 83.1% <85.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/simcore_postgres_database/utils_aiosqlalchemy.py 0.0% <0.0%> (ø)
...e/src/simcore_postgres_database/utils_aiopg_orm.py 84.5% <100.0%> (ø)
.../simcore_service_api_server/models/schemas/jobs.py 94.8% <100.0%> (ø)
.../simcore_service_api_server/models/schemas/meta.py 100.0% <100.0%> (ø)
...mcore_service_catalog/api/dependencies/database.py 100.0% <100.0%> (ø)
...g/src/simcore_service_catalog/models/domain/dag.py 100.0% <100.0%> (ø)

... and 309 files with indirect coverage changes

@pcrespov pcrespov changed the title WIP: 🔨♻️ Fixes mypy issue after upgrade 🔨♻️ Fixes mypy issue after upgrade Apr 16, 2023
@pcrespov pcrespov marked this pull request as ready for review April 16, 2023 19:04
@pcrespov pcrespov enabled auto-merge (squash) April 16, 2023 19:04
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codeclimate
Copy link

codeclimate bot commented Apr 17, 2023

Code Climate has analyzed commit 3645811 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit cb8779e into ITISFoundation:master Apr 17, 2023
@pcrespov pcrespov deleted the fix/mypy-upgrade branch April 17, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants