Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Webserver: Allow to disable auto-start of dynamic services #4103

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 13, 2023

What do these changes do?

  • add query parameter in the /open entrypoint to tell the backend how many dynamic services shall auto-start (between 0 and ENV variable)
    /projects/{project_id}:open?disable_service_auto_start=true will prevent any dynamic service to start
    @odeimaiz

Related issue/s

fixes #4074

How to test

DevOps Checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Apr 13, 2023
@sanderegg sanderegg added this to the Jelly Beans milestone Apr 13, 2023
@sanderegg sanderegg self-assigned this Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #4103 (1903609) into master (ae41466) will decrease coverage by 1.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4103      +/-   ##
=========================================
- Coverage    84.7%   83.0%    -1.7%     
=========================================
  Files         952     398     -554     
  Lines       41329   20621   -20708     
  Branches      957     174     -783     
=========================================
- Hits        35023   17130   -17893     
+ Misses       6087    3442    -2645     
+ Partials      219      49     -170     
Flag Coverage Δ
integrationtests 66.6% <50.0%> (+4.9%) ⬆️
unittests 84.0% <100.0%> (+1.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/projects/projects_api.py 93.9% <ø> (ø)
...re_service_webserver/projects/projects_handlers.py 90.9% <100.0%> (+0.5%) ⬆️

... and 646 files with indirect coverage changes

@sanderegg sanderegg force-pushed the enhancement/allow_to_open_study_without_opening_services branch from 07bd22e to 1903609 Compare April 14, 2023 08:27
@sanderegg sanderegg requested a review from odeimaiz April 14, 2023 08:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Apr 14, 2023

Code Climate has analyzed commit 1903609 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg marked this pull request as ready for review April 14, 2023 08:28
@sanderegg sanderegg changed the title ✨Webserver: Allow to override the number of auto-started dynamic services ✨Webserver: Allow to disable auto-start of dynamic services Apr 14, 2023
@sanderegg sanderegg merged commit 61d2543 into ITISFoundation:master Apr 14, 2023
@sanderegg sanderegg deleted the enhancement/allow_to_open_study_without_opening_services branch April 14, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to open a study and specify to not auto-start any service
4 participants