Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ—‘๏ธ Removes coveralls for test coverage #4099

Merged
merged 13 commits into from
Apr 13, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 12, 2023

What do these changes do?

Highlights on updated libraries (only updated libraries are included)

  • #packages before: 9
  • #packages after : 1
# name before after upgrade count packages
1 certifi 2022.12.7 ๐Ÿ—‘๏ธ removed 5 dask-task-models-library๐Ÿงช
models-library๐Ÿงช
postgres-database๐Ÿงช
service-integration๐Ÿงช
settings-library๐Ÿงช
2 charset-normalizer 3.0.1 ๐Ÿ—‘๏ธ removed 4 datcore-adapter๐Ÿงช
invitations๐Ÿงช
service-integration๐Ÿงช
settings-library๐Ÿงช
3 coverage 6.5.0, 7.2.1 7.2.3 22 agent๐Ÿงช
api-server๐Ÿงช
autoscaling๐Ÿงช
catalog๐Ÿงช
dask-sidecar๐Ÿงช
dask-task-models-library๐Ÿงช
datcore-adapter๐Ÿงช
director-v2๐Ÿงช
dynamic-sidecar๐Ÿงช
invitations๐Ÿงช
models-library๐Ÿงช
osparc-gateway-server๐Ÿงช๐Ÿงช
postgres-database๐Ÿงช
public-api๐Ÿงช
service-integration๐Ÿงช
service-library๐Ÿงช
settings-library๐Ÿงช
simcore-sdk๐Ÿงช
storage๐Ÿงช
swarm-deploy๐Ÿงช
web๐Ÿงช
4 coveralls 2.1.2, 3.3.1 ๐Ÿ—‘๏ธ removed 19 agent๐Ÿงช
api-server๐Ÿงช
autoscaling๐Ÿงช
catalog๐Ÿงช
dask-sidecar๐Ÿงช
dask-task-models-library๐Ÿงช
datcore-adapter๐Ÿงช
director-v2๐Ÿงช
director๐Ÿงช
invitations๐Ÿงช
models-library๐Ÿงช
osparc-gateway-server๐Ÿงช
postgres-database๐Ÿงช
service-integration๐Ÿงช
service-library๐Ÿงช
settings-library๐Ÿงช
simcore-sdk๐Ÿงช
storage๐Ÿงช
web๐Ÿงช
5 docopt 0.6.2 ๐Ÿ—‘๏ธ removed 18 agent๐Ÿงช
api-server๐Ÿงช
autoscaling๐Ÿงช
catalog๐Ÿงช
dask-sidecar๐Ÿงช
dask-task-models-library๐Ÿงช
datcore-adapter๐Ÿงช
director-v2๐Ÿงช
invitations๐Ÿงช
models-library๐Ÿงช
osparc-gateway-server๐Ÿงช
postgres-database๐Ÿงช
service-integration๐Ÿงช
service-library๐Ÿงช
settings-library๐Ÿงช
simcore-sdk๐Ÿงช
storage๐Ÿงช
web๐Ÿงช
6 idna 3.4 ๐Ÿ—‘๏ธ removed 2 service-integration๐Ÿงช
settings-library๐Ÿงช
7 pytest-cov 4.0.0 ๐Ÿ—‘๏ธ removed 2 public-api๐Ÿงช
swarm-deploy๐Ÿงช
8 requests 2.28.2 ๐Ÿ—‘๏ธ removed 7 dask-task-models-library๐Ÿงช
datcore-adapter๐Ÿงช
invitations๐Ÿงช
models-library๐Ÿงช
postgres-database๐Ÿงช
service-integration๐Ÿงช
settings-library๐Ÿงช
9 urllib3 1.26.12, 1.26.14 ๐Ÿ—‘๏ธ removed 7 dask-task-models-library๐Ÿงช
datcore-adapter๐Ÿงช
invitations๐Ÿงช
models-library๐Ÿงช
postgres-database๐Ÿงช
service-integration๐Ÿงช
settings-library๐Ÿงช

Legend:

  • โฌ†๏ธ base dependency (only services because packages are floating)
  • ๐Ÿงช test dependency
  • ๐Ÿ”ง tool dependency

Related issue/s

How to test

DevOps Checklist

@pcrespov pcrespov self-assigned this Apr 12, 2023
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Apr 12, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 12, 2023
@pcrespov pcrespov force-pushed the maintenance/week15 branch from dd51c16 to f80d6e7 Compare April 12, 2023 16:19
@pcrespov pcrespov changed the title WIP: โฌ†๏ธ Maintenance/week15 WIP: ๐Ÿ—‘๏ธ Removes coveralls for test coverage Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #4099 (19395dd) into master (224cfd7) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4099     +/-   ##
========================================
+ Coverage    85.2%   85.4%   +0.1%     
========================================
  Files         916     952     +36     
  Lines       39577   41327   +1750     
  Branches      957     957             
========================================
+ Hits        33752   35321   +1569     
- Misses       5606    5787    +181     
  Partials      219     219             
Flag Coverage ฮ”
integrationtests 66.7% <รธ> (+<0.1%) โฌ†๏ธ
unittests 82.3% <รธ> (+0.3%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

@pcrespov pcrespov force-pushed the maintenance/week15 branch from f80d6e7 to e4edde3 Compare April 12, 2023 20:12
@pcrespov pcrespov changed the title WIP: ๐Ÿ—‘๏ธ Removes coveralls for test coverage ๐Ÿ—‘๏ธ Removes coveralls for test coverage Apr 12, 2023
@pcrespov pcrespov marked this pull request as ready for review April 12, 2023 21:57
@pcrespov pcrespov requested review from GitHK and Surfict as code owners April 12, 2023 21:57
@pcrespov pcrespov enabled auto-merge (squash) April 12, 2023 23:19
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

ci/github/system-testing/swarm-deploy.bash Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Apr 13, 2023

Code Climate has analyzed commit 19395dd and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov disabled auto-merge April 13, 2023 15:17
@pcrespov pcrespov merged commit 10d1ef7 into ITISFoundation:master Apr 13, 2023
@pcrespov pcrespov deleted the maintenance/week15 branch April 13, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants