♻️ director-v2 uses one dy-sidecar API client per sidecar

[GitHK]

What do these changes do?

The connection pool from httpx inside director-v2's dynamic_sidecar_client is running out of connections.

♻️ Changed to be using one client per sidecar now. Trying to mitigate the problem.

Related issue/s

• closes director-v2 shared client connection pool runs out of clients #3944
• improving dynamic-sidecar design osparc-issues#638

How to test

Tests already exist.

[codecov]

Codecov Report

Merging #4085 (bcf726a) into master (c032fb5) will decrease coverage by 13.3%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #4085      +/-   ##
=========================================
- Coverage    85.5%   72.2%   -13.3%     
=========================================
  Files         951     398     -553     
  Lines       41264   20612   -20652     
  Branches      957     174     -783     
=========================================
- Hits        35290   14902   -20388     
+ Misses       5755    5661      -94     
+ Partials      219      49     -170     

Flag	Coverage Δ
integrationtests	66.6% <96.2%> (-0.1%)	⬇️
unittests	86.2% <77.7%> (+3.8%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ce_director_v2/api/dependencies/dynamic_sidecar.py	85.7% <ø> (+5.7%)	⬆️
..._v2/modules/dynamic_sidecar/api_client/__init__.py	100.0% <ø> (ø)
...ules/dynamic_sidecar/scheduler/_core/_scheduler.py	78.7% <ø> (ø)
...or-v2/src/simcore_service_director_v2/cli/_core.py	87.4% <100.0%> (-0.1%)	⬇️
...r_v2/modules/dynamic_sidecar/api_client/_public.py	92.3% <100.0%> (+0.1%)	⬆️
...modules/dynamic_sidecar/scheduler/_core/_events.py	97.2% <100.0%> (ø)
...s/dynamic_sidecar/scheduler/_core/_events_utils.py	91.5% <100.0%> (ø)
...ynamic_sidecar/scheduler/_core/_scheduler_utils.py	100.0% <100.0%> (ø)

... and 707 files with indirect coverage changes

[sanderegg]

thanks!

[sanderegg]

thanks!

[pcrespov]

let's hope this will solve the pool issue!
thx

[codeclimate]

Code Climate has analyzed commit bcf726a and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication