Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Dask: fix issue with disappearing workers #4057

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 3, 2023

What do these changes do?

During heavy testing, it was observed that some errors are arising due to the fact that workers are disappearing from the gateway due to auto-adaptation of the number of workers.
This should fix this problem.

Related issue/s

How to test

@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Apr 3, 2023
@sanderegg sanderegg added this to the Jelly Beans milestone Apr 3, 2023
@sanderegg sanderegg requested a review from pcrespov as a code owner April 3, 2023 15:49
@sanderegg sanderegg self-assigned this Apr 3, 2023
@sanderegg sanderegg requested a review from GitHK as a code owner April 3, 2023 15:49
@codeclimate
Copy link

codeclimate bot commented Apr 3, 2023

Code Climate has analyzed commit 473cb5d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #4057 (473cb5d) into master (661a727) will decrease coverage by 9.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4057      +/-   ##
=========================================
- Coverage    80.1%   70.8%    -9.3%     
=========================================
  Files         949     397     -552     
  Lines       41226   20579   -20647     
  Branches      957     174     -783     
=========================================
- Hits        33026   14577   -18449     
+ Misses       7981    5953    -2028     
+ Partials      219      49     -170     
Flag Coverage Δ
integrationtests 61.8% <16.6%> (-0.1%) ⬇️
unittests 86.2% <100.0%> (+9.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_director_v2/modules/dask_client.py 93.4% <100.0%> (+0.2%) ⬆️

... and 643 files with indirect coverage changes

@sanderegg sanderegg merged commit 0e4bf95 into ITISFoundation:master Apr 3, 2023
@sanderegg sanderegg deleted the dask/fix_issue_with_disappearing_workers branch April 3, 2023 16:51
@matusdrobuliak66 matusdrobuliak66 changed the title 🐛Dask: fix issue with disappearing workers 🐛 Dask: fix issue with disappearing workers Apr 4, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 4, 2023
25 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 20, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppTeam Std Simulations on S4L/AWS M1-12 Maintenance and DevOps
3 participants