Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Dask gateway: add traefik proxy for http(s) access #4039

Closed

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • add a traefik proxy in the dask-gateway docker-compose
  • the idea is to provide https access

Related issue/s

How to test

@sanderegg sanderegg added a:dask-service Any of the dask services: dask-scheduler/sidecar or worker changelog:✨new-feature labels Mar 28, 2023
@sanderegg sanderegg self-assigned this Mar 28, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 28, 2023

Code Climate has analyzed commit e3e13de and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #4039 (e3e13de) into master (935557a) will decrease coverage by 2.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4039      +/-   ##
=========================================
- Coverage    83.0%   80.4%    -2.7%     
=========================================
  Files         946       8     -938     
  Lines       40979     358   -40621     
  Branches      851       0     -851     
=========================================
- Hits        34034     288   -33746     
+ Misses       6736      70    -6666     
+ Partials      209       0     -209     
Flag Coverage Δ
integrationtests 80.4% <ø> (+34.4%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 941 files with indirect coverage changes

@pcrespov pcrespov added this to the Jelly Beans milestone Apr 10, 2023
@sanderegg sanderegg closed this Jun 8, 2023
@sanderegg sanderegg deleted the dask/add_traefik_proxy branch June 8, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants