Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Dask gateway: add missing variables + change deprecated calls #4022

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 23, 2023

What do these changes do?

  • dask deprecated dask-worker in favor of dask worker
  • dask deprecated dask-scheduler in favor of dask scheduler
  • added variables in default docker-compose file of gateway

Related issue/s

How to test

@sanderegg sanderegg added a:dask-service Any of the dask services: dask-scheduler/sidecar or worker changelog:♻️refactor labels Mar 23, 2023
@sanderegg sanderegg added this to the Mithril milestone Mar 23, 2023
@sanderegg sanderegg self-assigned this Mar 23, 2023
@sanderegg sanderegg enabled auto-merge (squash) March 23, 2023 12:11
services/dask-sidecar/docker/boot.sh Show resolved Hide resolved
@sanderegg sanderegg force-pushed the dask/add_variables branch from 35a99eb to f0ec86f Compare March 23, 2023 12:23
@codeclimate
Copy link

codeclimate bot commented Mar 23, 2023

Code Climate has analyzed commit f0ec86f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #4022 (f0ec86f) into master (0d96bd1) will decrease coverage by 6.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4022      +/-   ##
=========================================
- Coverage    81.6%   75.0%    -6.7%     
=========================================
  Files         777      19     -758     
  Lines       34772    1075   -33697     
  Branches      404       0     -404     
=========================================
- Hits        28405     807   -27598     
+ Misses       6277     268    -6009     
+ Partials       90       0      -90     
Flag Coverage Δ
unittests 75.0% <ø> (-6.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 780 files with indirect coverage changes

@sanderegg sanderegg merged commit 2adcaec into ITISFoundation:master Mar 23, 2023
@sanderegg sanderegg deleted the dask/add_variables branch March 23, 2023 13:21
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 20, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppTeam Std Simulations on S4L/AWS M1-12 Maintenance and DevOps Dask clusters issues
4 participants