✨ ooil executable in a docker image #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3458 +/- ##
========================================
- Coverage 83.4% 78.4% -5.0%
========================================
Files 828 792 -36
Lines 35183 33460 -1723
Branches 740 741 +1
========================================
- Hits 29363 26257 -3106
- Misses 5632 7026 +1394
+ Partials 188 177 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
force-pushed
the
is3418/ooil-fsgenerator
branch
from
75b934c to
604cb82
Compare
pcrespov
changed the title
pcrespov
requested review from
sanderegg,
Surfict,
mrnicegyu11 and
GitHK
as code owners
|
@GitHK @sanderegg any hints on how to solve any of these mypy issues appreciated :-) |
mrnicegyu11
reviewed
Oct 25, 2022
GitHK
reviewed
Oct 25, 2022
There was a problem hiding this comment.
I've got a few questions:
- We already have ci-service-integration-library which is published to GitHub that already contains
ooil. - Why is this an image that is not part of simcore released with simcore?
- Where it will be pushed, how it will be versioned?
- How would this be used?
sanderegg
approved these changes
Oct 25, 2022
packages/service-integration/src/service_integration/osparc_image_specs.py
Outdated
Show resolved
Hide resolved
packages/service-integration/src/service_integration/osparc_image_specs.py
Outdated
Show resolved
Hide resolved
Comment on lines
+23
to
+25
| org.opencontainers.image.created: "${BUILD_DATE}" | ||
| org.opencontainers.image.source: "${VCS_URL}" | ||
| org.opencontainers.image.revision: "${VCS_REF}" |
There was a problem hiding this comment.
is that the new standard? shall we create an issue and change them all?
There was a problem hiding this comment.
yes. I will update the others in a separate maintenance PR. There are other entries I want to add.
| @@ -31,3 +31,172 @@ dask*-space/ | |||
|
|
|||
| # mypy cache | |||
| **/.mypy_cache/ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
just a thought but: the idea with dockerignore files I think are:
- ignore everything
* - then only add what is necessary as this is used in the docker build to set up the context and might make the build magnitudes faster. I guess I will review this one of these Fridays
There was a problem hiding this comment.
I've got a few questions:
- We already have ci-service-integration-library which is published to GitHub that already contains
ooil.- Why is this an image that is not part of simcore released with simcore?
- Where it will be pushed, how it will be versioned?
- How would this be used?
discussed offline
There was a problem hiding this comment.
just a thought but: the idea with dockerignore files I think are:
- ignore everything
*- then only add what is necessary as this is used in the docker build to set up the context and might make the build magnitudes faster. I guess I will review this one of these Fridays
In principle I agree with this approach but IMO there is a flaw. Say that you want to include packages/servicelib. Using your approach you exclude everything except whatever is in that folder. The problem is, what happens e.g. with all the artifacts produced for python development (i.e. __cache__, eggs, etc) inside of that folder? Shouldn't it make sense that the .dockerignore includes as well the .gitignore?
GitHK
approved these changes
Oct 25, 2022
| @@ -2,10 +2,11 @@ | |||
| # filename: https://raw.githubusercontent.com/compose-spec/compose-spec/master/schema/compose-spec.json | |||
| # timestamp: 2021-11-19T10:40:07+00:00 | |||
|
|
|||
| from __future__ import annotations | |||
| # type: ignore | |||
There was a problem hiding this comment.
why is this at the beginning of the file?
There was a problem hiding this comment.
to ignore the entire file from mypy. Thisi s auto-generated
packages/service-integration/src/service_integration/osparc_config.py
Outdated
Show resolved
Hide resolved
pcrespov
force-pushed
the
is3418/ooil-fsgenerator
branch
from
1b51983 to
5c8b065
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
service-integrationexecutableooilis now released as an image. NOTE that this is NOT a new stack service!services/docker-compose-build.ymlso that the image is published and tagged analogous to the rest of the service stack imagesmake mypy).gitginoreas part of.dockerignoreVCS_REFtakes now entire commit SHAsample/sleepers.pyRelated issue/s
How to test
cd packages/service-integration make build make inspect docker run -it local/service-integration:production --version