-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ App Mode: Allow uploading file to File Picker #3383
Merged
odeimaiz
merged 18 commits into
ITISFoundation:master
from
odeimaiz:feature/fp-ss-upload-file
Sep 23, 2022
Merged
✨ App Mode: Allow uploading file to File Picker #3383
odeimaiz
merged 18 commits into
ITISFoundation:master
from
odeimaiz:feature/fp-ss-upload-file
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
issue affecting the front-end (area group)
changelog:🎨enhancement
labels
Sep 22, 2022
odeimaiz
changed the title
text updated
WIP: App Mode: Allow uploading file to File Picker
Sep 22, 2022
odeimaiz
changed the title
WIP: App Mode: Allow uploading file to File Picker
WIP: ✨ App Mode: Allow uploading file to File Picker
Sep 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #3383 +/- ##
======================================
Coverage 83.0% 83.0%
======================================
Files 811 811
Lines 34416 34416
Branches 1358 1358
======================================
+ Hits 28571 28585 +14
+ Misses 5664 5650 -14
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
odeimaiz
changed the title
WIP: ✨ App Mode: Allow uploading file to File Picker
✨ App Mode: Allow uploading file to File Picker
Sep 23, 2022
pcrespov
approved these changes
Sep 23, 2022
Kudos, SonarCloud Quality Gate passed! |
GitHK
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
sanderegg
approved these changes
Sep 23, 2022
sanderegg
pushed a commit
that referenced
this pull request
Sep 23, 2022
(cherry picked from commit a53bc45)
pcrespov
pushed a commit
that referenced
this pull request
Sep 29, 2022
(cherry picked from commit a53bc45)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
File Picker was redesigned to support file uploading in both App and Workbench mode. Requested by @newton1985.
File Picker in App mode:
File Picker in Workbench mode:
Related issue/s
related to ITISFoundation/osparc-issues#670
How to test
Checklist