Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ App Mode: Allow uploading file to File Picker #3383

Merged
merged 18 commits into from
Sep 23, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 22, 2022

What do these changes do?

File Picker was redesigned to support file uploading in both App and Workbench mode. Requested by @newton1985.

File Picker in App mode:
FP-App

File Picker in Workbench mode:
FP-WB

Related issue/s

related to ITISFoundation/osparc-issues#670

How to test

Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Sep 22, 2022
@odeimaiz odeimaiz added this to the vaporwave milestone Sep 22, 2022
@odeimaiz odeimaiz self-assigned this Sep 22, 2022
@odeimaiz odeimaiz changed the title text updated WIP: App Mode: Allow uploading file to File Picker Sep 22, 2022
@odeimaiz odeimaiz changed the title WIP: App Mode: Allow uploading file to File Picker WIP: ✨ App Mode: Allow uploading file to File Picker Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #3383 (de95d27) into master (d0b5801) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3383   +/-   ##
======================================
  Coverage    83.0%   83.0%           
======================================
  Files         811     811           
  Lines       34416   34416           
  Branches     1358    1358           
======================================
+ Hits        28571   28585   +14     
+ Misses       5664    5650   -14     
  Partials      181     181           
Flag Coverage Δ
integrationtests 68.5% <ø> (-0.1%) ⬇️
unittests 79.8% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...storage/src/simcore_service_storage/dsm_cleaner.py 94.5% <0.0%> (-5.5%) ⬇️
...rc/simcore_service_catalog/db/repositories/dags.py 44.4% <0.0%> (-2.8%) ⬇️
...simcore_service_director_v2/modules/node_rights.py 98.1% <0.0%> (-1.0%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 83.4% <0.0%> (-0.8%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 89.6% <0.0%> (ø)
...imcore_service_webserver/garbage_collector_core.py 64.4% <0.0%> (+2.4%) ⬆️
.../simcore_service_catalog/db/repositories/groups.py 70.2% <0.0%> (+2.7%) ⬆️
...c/simcore_service_catalog/core/background_tasks.py 70.5% <0.0%> (+5.2%) ⬆️
...ore_service_director_v2/utils/dask_client_utils.py 86.9% <0.0%> (+6.0%) ⬆️
...rvice_datcore_adapter/utils/requests_decorators.py 83.7% <0.0%> (+8.1%) ⬆️

@odeimaiz odeimaiz changed the title WIP: ✨ App Mode: Allow uploading file to File Picker ✨ App Mode: Allow uploading file to File Picker Sep 23, 2022
@odeimaiz odeimaiz marked this pull request as ready for review September 23, 2022 06:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit a53bc45 into ITISFoundation:master Sep 23, 2022
sanderegg pushed a commit that referenced this pull request Sep 23, 2022
pcrespov pushed a commit that referenced this pull request Sep 29, 2022
@odeimaiz odeimaiz deleted the feature/fp-ss-upload-file branch August 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants