Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨FE: Expiration date #3349

Merged
merged 21 commits into from
Sep 14, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 12, 2022

What do these changes do?

  • Alert users when the account expires in less than 7 days
  • Show expiration date in Profile Page

Bonus:

  • Atomic calls for updating profile
  • UserMenuButton bound to first name
  • Bugfix: Unknown Label in files tree are now known

expirationDate

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Sep 12, 2022
@odeimaiz odeimaiz added this to the vaporwave milestone Sep 12, 2022
@odeimaiz odeimaiz self-assigned this Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #3349 (358cd6f) into master (0cc9c76) will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3349     +/-   ##
========================================
- Coverage    82.9%   82.4%   -0.6%     
========================================
  Files         807     807             
  Lines       34208   34208             
  Branches     1359    1359             
========================================
- Hits        28378   28188    -190     
- Misses       5648    5852    +204     
+ Partials      182     168     -14     
Flag Coverage Δ
integrationtests 67.7% <ø> (-0.6%) ⬇️
unittests 79.5% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...k/src/simcore_sdk/node_ports_common/filemanager.py 27.5% <0.0%> (-55.8%) ⬇️
...src/simcore_sdk/node_ports_common/file_io_utils.py 33.8% <0.0%> (-51.7%) ⬇️
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py 42.4% <0.0%> (-43.9%) ⬇️
...e-sdk/src/simcore_sdk/node_ports_common/r_clone.py 75.4% <0.0%> (-20.8%) ⬇️
...re_sdk/node_ports_common/client_session_manager.py 92.3% <0.0%> (-7.7%) ⬇️
...ore_service_director_v2/utils/dask_client_utils.py 81.7% <0.0%> (-5.3%) ⬇️
...re-sdk/src/simcore_sdk/node_ports_v2/port_utils.py 65.3% <0.0%> (-5.0%) ⬇️
...dk/src/simcore_sdk/node_ports_common/exceptions.py 65.6% <0.0%> (-4.5%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 80.0% <0.0%> (-3.4%) ⬇️
...rc/simcore_sdk/node_ports_common/storage_client.py 81.4% <0.0%> (-2.5%) ⬇️
... and 12 more

@odeimaiz odeimaiz marked this pull request as ready for review September 13, 2022 14:41
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Minor comments.

@odeimaiz odeimaiz changed the title WIP: ✨FE: Expiration date ✨FE: Expiration date Sep 13, 2022
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tremendeous

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit eca0268 into ITISFoundation:master Sep 14, 2022
@odeimaiz odeimaiz deleted the feature/fe-expire-account branch September 14, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants