Dynamic services to use storage #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re into feature/FE-DSM
…re into feature/FE-DSM
This reverts commit cd37313.
re-generated storage client sdk
re-generated client
added route to start pipeline
fixed looking for service dependencies
add storage endpoint to sidecar so it can use it
sanderegg
changed the title
odeimaiz
approved these changes
Nov 16, 2018
mguidon
approved these changes
Nov 16, 2018
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
added openapi for start pipeline in webserver + created workbench jsonschema (NOTE: duplicate of a subpart of project-v0.0.1.json) - validation not yet working
added openapi for start/stop of dynamic services in webserver, forwards to director
migrated startDynamic/stopDynamic from websocket interface to webserver rest API, updated front-end
updated frontend to send startpipeline to new rest API
updated node_ports package to use the storage service and use user ID (connects DSM: metadata and openapi #243)
simplified usage of node_ports (connects Notebooks for demo #305)
updated sidecar to use new async node_ports and get user ID
director passes storage endpoint and user id to dynamic services
bonus
Related issue number
closes #243, connects #305
Checklist