-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add ENV to prevent copying if project too large (⚠️ devops) #3286
✨ Add ENV to prevent copying if project too large (⚠️ devops) #3286
Conversation
a253414
to
c854258
Compare
Codecov Report
@@ Coverage Diff @@
## master #3286 +/- ##
========================================
- Coverage 83.2% 80.9% -2.4%
========================================
Files 682 722 +40
Lines 30068 30760 +692
Branches 3841 3952 +111
========================================
- Hits 25044 24888 -156
- Misses 4227 5075 +848
Partials 797 797
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the js part looks awesome 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Some comments below for your consideration :-)
d385380
to
2da0ae0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
To prevent unnecessary problems a check on the project total data size is done and prevents a user to copy enormous amount of data that might lead to issues in the osparc platform.
The idea of this ENV is to allow to progressively increase that limit based on tests.
PROJECTS_MAX_COPY_SIZE_BYTES
contains the maximum amount in bytes of a project that can be copied (default is currently set to 30GB)Related issue/s
related to ITISFoundation/osparc-issues#558
How to test
Checklist