Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "✨🐛 making dy-sidecar resilient to restarts (#3239)" #3277

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 22, 2022

This reverts commit 25e7ca9 until issue with volumes remover is solved

@pcrespov pcrespov self-assigned this Aug 22, 2022
@pcrespov pcrespov added this to the Brutalism milestone Aug 22, 2022
@pcrespov pcrespov marked this pull request as ready for review August 22, 2022 08:43
@pcrespov pcrespov requested a review from GitHK as a code owner August 22, 2022 08:43
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #3277 (d58564a) into master (d58564a) will not change coverage.
The diff coverage is n/a.

❗ Current head d58564a differs from pull request most recent head 71a399d. Consider uploading reports for the commit 71a399d to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3277   +/-   ##
======================================
  Coverage    78.5%   78.5%           
======================================
  Files         713     713           
  Lines       31108   31108           
  Branches     3930    3930           
======================================
  Hits        24441   24441           
  Misses       5870    5870           
  Partials      797     797           
Flag Coverage Δ
integrationtests 66.4% <0.0%> (ø)
unittests 75.6% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 2f6151b into ITISFoundation:master Aug 22, 2022
@pcrespov pcrespov deleted the fix/revert-3239 branch August 22, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants