Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 is91/front-end side implementation of 2FA (⚠️ devops) #3264

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 15, 2022

What do these changes do?

Takes changes in web/client developed in PR #3231 by @odeimaiz

Registration:
2fa

Login:
2fa_login

⚠️ devops
VERY IMPORTANT:

  • Cherry-Pick Redis-Commander changes from d67532c
  • Take redis and redis commander down (scale to zero), remove redis docker volume, assert change took place

Related issue/s

How to test

Checklist

  • manual testing
  • Openapi changes? make openapi-specs, git commit ... and then make version-*)
  • Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov changed the title is91/front-end implementation of 2FA is91/front-end side implementation of 2FA Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #3264 (a590097) into master (339596a) will increase coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3264     +/-   ##
========================================
+ Coverage    81.6%   82.3%   +0.6%     
========================================
  Files         752     752             
  Lines       32119   32119             
  Branches     4110    4110             
========================================
+ Hits        26231   26446    +215     
+ Misses       5036    4829    -207     
+ Partials      852     844      -8     
Flag Coverage Δ
integrationtests 66.4% <ø> (-0.1%) ⬇️
unittests 78.7% <ø> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_director_v2/modules/node_rights.py 97.2% <0.0%> (-1.0%) ⬇️
...c/simcore_service_catalog/core/background_tasks.py 62.1% <0.0%> (+1.0%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 77.6% <0.0%> (+1.0%) ⬆️
.../simcore_service_catalog/services/access_rights.py 81.2% <0.0%> (+2.5%) ⬆️
...mcore_service_webserver/garbage_collector_utils.py 82.0% <0.0%> (+2.5%) ⬆️
.../simcore_service_catalog/db/repositories/groups.py 75.6% <0.0%> (+2.7%) ⬆️
...ore_service_director_v2/utils/dask_client_utils.py 82.6% <0.0%> (+4.3%) ⬆️
...imcore_service_webserver/garbage_collector_task.py 100.0% <0.0%> (+4.6%) ⬆️
...mcore_service_webserver/projects/projects_utils.py 85.0% <0.0%> (+5.0%) ⬆️
...simcore_service_webserver/director_v2_core_base.py 84.2% <0.0%> (+7.8%) ⬆️
... and 8 more

@pcrespov pcrespov changed the title is91/front-end side implementation of 2FA WIP: is91/front-end side implementation of 2FA Aug 15, 2022
@pcrespov pcrespov changed the title WIP: is91/front-end side implementation of 2FA WIP: 💄 is91/front-end side implementation of 2FA Aug 15, 2022
@pcrespov pcrespov added this to the Brutalism milestone Aug 15, 2022
@pcrespov pcrespov added the a:frontend issue affecting the front-end (area group) label Aug 15, 2022
@odeimaiz odeimaiz changed the title WIP: 💄 is91/front-end side implementation of 2FA 💄 is91/front-end side implementation of 2FA Aug 16, 2022
@odeimaiz odeimaiz marked this pull request as ready for review August 16, 2022 08:09
@odeimaiz odeimaiz self-requested a review as a code owner August 16, 2022 08:09
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's legal that I approve it 🙃

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit b17ac3e into ITISFoundation:master Aug 16, 2022
@pcrespov pcrespov deleted the is91/client-2FA branch August 16, 2022 11:25
@mrnicegyu11 mrnicegyu11 changed the title 💄 is91/front-end side implementation of 2FA 💄 is91/front-end side implementation of 2FA (⚠️ devops) Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants