Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend side: Long running creation of studies #3260

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 15, 2022

What do these changes do?

Updated endpoints that require polling:

  • New empty Study
  • Study from Template
  • Study to Template
  • Duplicate Study

New Study:
NewStudy

Study from Template:
StudyFromTemplate

Study to Template (the first attempt fails because my storage is not working):
StudyToTemplate

Duplicate Study:
DuplicateStudy

Related issue/s

Related to help with ITISFoundation/osparc-issues#558

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Aug 17, 2022
@odeimaiz odeimaiz changed the title WIP: Frontend side: Long running creation of studies ✨ Frontend side: Long running creation of studies Aug 17, 2022
@odeimaiz odeimaiz marked this pull request as ready for review August 17, 2022 10:25
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanderegg which should we review/merge: this PR or #3235 ??

@sanderegg
Copy link
Member

@sanderegg which should we review/merge: this PR or #3235 ??

@pcrespv: as stated, this one builds on top of the backend PR #3235. If you review #3235 you review the backend side, this one adds the frontend on top.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elisabettai
Copy link
Collaborator

For the duplication (and Study to Template, I guess), maybe we can add some kind of warning for the user (together with the messages you have already), e.g. "This might take a while, please don't refresh the tab while it's running".

@sanderegg sanderegg merged commit fb1d8ad into ITISFoundation:master Aug 18, 2022
@odeimaiz odeimaiz deleted the sanderegg-enhancement/long_running_creation_of_studies_2 branch August 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants