Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixed flaky director-v2 test #3252

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 11, 2022

What do these changes do?

Inside the pydantic model state_exclude is a set, since it will not preserve the order. We sort result after it's being parsed.

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK marked this pull request as ready for review August 11, 2022 14:10
@GitHK GitHK self-assigned this Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3252 (0e99b1b) into master (c765a51) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 0e99b1b differs from pull request most recent head 9042d62. Consider uploading reports for the commit 9042d62 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3252     +/-   ##
========================================
- Coverage    83.3%   83.3%   -0.1%     
========================================
  Files         676     676             
  Lines       29708   29708             
  Branches     3806    3806             
========================================
- Hits        24776   24751     -25     
- Misses       4157    4180     +23     
- Partials      775     777      +2     
Flag Coverage Δ
integrationtests 66.6% <ø> (-0.1%) ⬇️
unittests 79.5% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/dynamic_sidecar/docker_service_specs/sidecar.py 80.8% <ø> (ø)
...rvice_datcore_adapter/utils/requests_decorators.py 68.4% <0.0%> (-10.6%) ⬇️
...ector_v2/modules/comp_scheduler/background_task.py 83.3% <0.0%> (-8.4%) ⬇️
...ore_service_director_v2/utils/dask_client_utils.py 79.1% <0.0%> (-3.5%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 73.3% <0.0%> (-3.4%) ⬇️
.../simcore_service_catalog/db/repositories/groups.py 70.2% <0.0%> (-2.8%) ⬇️
.../simcore_service_catalog/services/access_rights.py 78.7% <0.0%> (-2.5%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <0.0%> (-1.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.7% <0.0%> (-1.5%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-0.7%) ⬇️
... and 3 more

@GitHK GitHK added a:director-v2 issue related with the director-v2 service changelog:🐛bugfix labels Aug 11, 2022
@GitHK GitHK added this to the Brutalism milestone Aug 11, 2022
@GitHK GitHK changed the title 🐛 fixed issue with flaky tests 🐛 fixed flaky director-v2 test Aug 11, 2022
@sanderegg sanderegg force-pushed the pr-osparc-fix-flaky-state-paths branch from 0e99b1b to 2b2499b Compare August 11, 2022 16:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@pcrespov pcrespov merged commit bd9919f into ITISFoundation:master Aug 11, 2022
@GitHK GitHK deleted the pr-osparc-fix-flaky-state-paths branch August 11, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants