-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fixed flaky director-v2 test #3252
🐛 fixed flaky director-v2 test #3252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3252 +/- ##
========================================
- Coverage 83.3% 83.3% -0.1%
========================================
Files 676 676
Lines 29708 29708
Branches 3806 3806
========================================
- Hits 24776 24751 -25
- Misses 4157 4180 +23
- Partials 775 777 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/director-v2/tests/unit/test_modules_dynamic_sidecar_docker_service_specs.py
Outdated
Show resolved
Hide resolved
0e99b1b
to
2b2499b
Compare
…ocker_service_specs.py
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Inside the pydantic model
state_exclude
is aset
, since it will not preserve the order. We sort result after it's being parsed.Related issue/s
How to test
Checklist