-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Is638/dynamic sidecar (round 5) #3165
♻️ Is638/dynamic sidecar (round 5) #3165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3165 +/- ##
========================================
- Coverage 81.7% 81.7% -0.1%
========================================
Files 723 724 +1
Lines 30933 30976 +43
Branches 4001 4005 +4
========================================
+ Hits 25298 25322 +24
- Misses 4818 4835 +17
- Partials 817 819 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dc0376c
to
1e0cb46
Compare
packages/pytest-simcore/src/pytest_simcore/helpers/typing_env.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/task.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/task.py
Outdated
Show resolved
Hide resolved
…g: cannot collect test class 'TestThickClient' because it has a __init__ constructor (from: tests/unit/test_modules_dynamic_sidecar_client_api_base.py) class TestThickClient(BaseThinClient):
92d6617
to
f61bcd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks.
Please find some minor maybe suggestions.
packages/pytest-simcore/src/pytest_simcore/helpers/utils_envs.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/utils_envs.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/task.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/task.py
Show resolved
Hide resolved
services/director-v2/tests/unit/test_modules_dynamic_sidecar_docker_service_specs.py
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers.py
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers_extension.py
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers_extension.py
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
This PR is mostly addressing some helper functions and tooling. It is a bit noisy but the most relevant changes are:
pytest_simcore
pytest_simcore.helpers.utils_envs
servicelib
:test_errors.py
and inupdate_failing_status
)servicelib.fastapi.openapi.get_common_oas_options
adds default options for OAS info. In particular a server entry for development that shows in swagger doc. This will simplify manual testing an API by just going tohttp://127.0.0.1:$(published_port)/dev/doc
and getdirector-v2
:settings
: dy-sidecar is spawned in the same boot mode as the director-v2- in devel mode, dy-sidecar mounts volumes and exposes http and debugger ports as any other service.
dynamic-services
:id
in entrypointsRelated issue/s
How to test
CI of packages above