Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Is638/dynamic sidecar refactors layout (round 4) #3156

Merged
merged 22 commits into from
Jul 1, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 30, 2022

What do these changes do?

The main goal of the PR is to simplify the layout of the service project.

Highlights:

  • ♻️ moves modules to reduce clutter in core and model sub-packages
  • ♻️ renames shared_handlesr to docker_compose_utils
    • timeout in dockr-compose calls raises now TimeoutError
    • moves all docker-compose call to that module
    • adds timeouts values to the API queries (experimental)
  • 🔨 adds linter tests for project: test__code_syntax.py

Related issue/s

How to test

CI

@pcrespov pcrespov self-assigned this Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #3156 (256d35f) into master (3374169) will increase coverage by 0.0%.
The diff coverage is 81.6%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3156   +/-   ##
======================================
  Coverage    81.6%   81.6%           
======================================
  Files         723     722    -1     
  Lines       30689   30688    -1     
  Branches     3966    3968    +2     
======================================
+ Hits        25071   25072    +1     
+ Misses       4797    4795    -2     
  Partials      821     821           
Flag Coverage Δ
integrationtests 66.2% <ø> (+<0.1%) ⬆️
unittests 78.1% <81.6%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_dynamic_sidecar/models/shared_store.py 100.0% <ø> (ø)
...simcore_service_dynamic_sidecar/core/validation.py 68.9% <40.0%> (+0.3%) ⬆️
...ervice_dynamic_sidecar/api/containers_extension.py 89.9% <50.0%> (+0.4%) ⬆️
.../simcore_service_dynamic_sidecar/api/containers.py 88.8% <73.3%> (-0.4%) ⬇️
.../src/simcore_service_dynamic_sidecar/core/utils.py 80.2% <75.0%> (+0.2%) ⬆️
...rvice_dynamic_sidecar/core/docker_compose_utils.py 92.5% <92.5%> (ø)
...mcore_service_dynamic_sidecar/api/_dependencies.py 100.0% <100.0%> (ø)
.../src/simcore_service_dynamic_sidecar/api/health.py 100.0% <100.0%> (ø)
...imcore_service_dynamic_sidecar/core/application.py 95.8% <100.0%> (ø)
...mcore_service_dynamic_sidecar/modules/nodeports.py 25.0% <100.0%> (+1.4%) ⬆️
... and 6 more

@pcrespov pcrespov added the a:dynamic-sidecar dynamic-sidecar service label Jun 30, 2022
@pcrespov pcrespov added this to the Diolkos milestone Jun 30, 2022
@pcrespov pcrespov marked this pull request as ready for review June 30, 2022 05:28
@pcrespov pcrespov changed the title ♻️ WIP: Is638/dynamic sidecar refactors layout (round 4) ♻️ Is638/dynamic sidecar refactors layout (round 4) Jun 30, 2022
@pcrespov pcrespov force-pushed the is638/dy-sidecar-round4 branch from d3a78af to c71f0df Compare June 30, 2022 10:00
@pcrespov pcrespov requested review from GitHK and sanderegg and removed request for sanderegg June 30, 2022 10:01
@pcrespov pcrespov force-pushed the is638/dy-sidecar-round4 branch from 8800653 to 13c487a Compare June 30, 2022 15:55
@pcrespov pcrespov force-pushed the is638/dy-sidecar-round4 branch from 213f8a1 to 256d35f Compare July 1, 2022 08:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 2ffa877 into ITISFoundation:master Jul 1, 2022
@pcrespov pcrespov deleted the is638/dy-sidecar-round4 branch July 1, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants