-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Is638/dynamic sidecar refactors layout (round 4) #3156
Merged
pcrespov
merged 22 commits into
ITISFoundation:master
from
pcrespov:is638/dy-sidecar-round4
Jul 1, 2022
Merged
♻️ Is638/dynamic sidecar refactors layout (round 4) #3156
pcrespov
merged 22 commits into
ITISFoundation:master
from
pcrespov:is638/dy-sidecar-round4
Jul 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3156 +/- ##
======================================
Coverage 81.6% 81.6%
======================================
Files 723 722 -1
Lines 30689 30688 -1
Branches 3966 3968 +2
======================================
+ Hits 25071 25072 +1
+ Misses 4797 4795 -2
Partials 821 821
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
requested review from
GitHK,
sanderegg,
colinRawlings,
mguidon and
odeimaiz
June 30, 2022 05:27
pcrespov
changed the title
♻️ WIP: Is638/dynamic sidecar refactors layout (round 4)
♻️ Is638/dynamic sidecar refactors layout (round 4)
Jun 30, 2022
sanderegg
approved these changes
Jun 30, 2022
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/utils.py
Outdated
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/validation.py
Show resolved
Hide resolved
sanderegg
approved these changes
Jun 30, 2022
GitHK
reviewed
Jun 30, 2022
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/validation.py
Show resolved
Hide resolved
pcrespov
force-pushed
the
is638/dy-sidecar-round4
branch
from
June 30, 2022 10:00
d3a78af
to
c71f0df
Compare
pcrespov
requested review from
GitHK and
sanderegg
and removed request for
sanderegg
June 30, 2022 10:01
GitHK
approved these changes
Jun 30, 2022
pcrespov
force-pushed
the
is638/dy-sidecar-round4
branch
from
June 30, 2022 15:55
8800653
to
13c487a
Compare
sanderegg
approved these changes
Jul 1, 2022
pcrespov
force-pushed
the
is638/dy-sidecar-round4
branch
from
July 1, 2022 08:57
213f8a1
to
256d35f
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The main goal of the PR is to simplify the layout of the service project.
Highlights:
core
andmodel
sub-packagesshared_handlesr
todocker_compose_utils
test__code_syntax.py
Related issue/s
How to test
CI