🐛 ♻️ Is3125/gc review

[pcrespov]

What do these changes do?

First review of incident #3125 lead to minor fixes and some refactoring to improve logging in the garbage collector (GC)

• 🐛 Fixes exception while handling exception due to wrong msg argument for DynamicSidecarError
• 🐛 Fixes default in servicelib.logging_utils.set_logging_handler
• ♻️ improves logs in GC ( e.g. context logs and info level)
• ♻️ holds a copy of task in app's store as app[GC_TASK] (currently only kept in local scope of run_background_task)
• ♻️ improves annotations in redis registry

Further analysis&fixes will follow in separate PRs.

Related issue/s

• After analysis of incident Incident Report: Consistent 100% CPU load on GPU node, GC fails to clean, (working) GC does not collect dy-services #3125

How to test

• CI covered

[codecov]

Codecov Report

Merging #3130 (f795396) into master (76171d1) will increase coverage by 0.0%.
The diff coverage is 89.3%.

@@          Coverage Diff           @@
##           master   #3130   +/-   ##
======================================
  Coverage    80.9%   80.9%           
======================================
  Files         706     706           
  Lines       30468   30490   +22     
  Branches     3948    3949    +1     
======================================
+ Hits        24666   24695   +29     
+ Misses       4956    4944   -12     
- Partials      846     851    +5     

Flag	Coverage Δ
integrationtests	65.9% <80.9%> (+<0.1%)	⬆️
unittests	77.2% <89.3%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/service-library/src/servicelib/logging_utils.py	0.0% <0.0%> (ø)
..._director_v2/modules/dynamic_sidecar/docker_api.py	89.0% <ø> (-0.5%)	⬇️
...imcore_service_webserver/garbage_collector_core.py	66.8% <84.2%> (-2.1%)	⬇️
...imcore_service_webserver/garbage_collector_task.py	97.6% <91.6%> (-2.4%)	⬇️
...mcore_service_webserver/garbage_collector_utils.py	82.0% <100.0%> (+2.6%)	⬆️
...ore_service_webserver/resource_manager/registry.py	94.8% <100.0%> (+0.6%)	⬆️
...ce_webserver/resource_manager/websocket_manager.py	93.5% <0.0%> (-1.3%)	⬇️
...src/simcore_service_webserver/socketio/handlers.py	81.5% <0.0%> (-1.0%)	⬇️
.../director/src/simcore_service_director/producer.py	61.6% <0.0%> (-0.9%)	⬇️
... and 9 more

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.4% Duplication

[mrnicegyu11]

lgtm, thx for this

[sanderegg]

thanks!

[GitHK]

👍