-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️🔒️ Maintenance/vulnerability upgrade for ujson, upgrade fastapi+starlette #3112
⬆️🔒️ Maintenance/vulnerability upgrade for ujson, upgrade fastapi+starlette #3112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3112 +/- ##
======================================
Coverage 82.9% 83.0%
======================================
Files 808 808
Lines 34261 34261
Branches 1358 1358
======================================
+ Hits 28419 28450 +31
+ Misses 5661 5630 -31
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2f17666
to
39d9f2e
Compare
0598c50
to
7876149
Compare
7876149
to
50b01da
Compare
41453bb
to
a8399d0
Compare
a8399d0
to
3e4e8c3
Compare
Kudos, SonarCloud Quality Gate passed!
|
3e4e8c3
to
36b7832
Compare
36b7832
to
de347a6
Compare
7906918
to
b145096
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
d7d04b6
to
56255a0
Compare
56255a0
to
b49c4cf
Compare
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
ujson
to overcome vulnerabilities CVE-2021-45958, GHSA-fh56-85cw-5pq6ujson
dependencies were introduced byfastapi
. By upgrading the latter, it pushed mainly the versions ofstarlette
andujson
. The problem is thatstarlette
broke parsing:
in routes Fix regression on route paths with colons encode/starlette#1675 (see failing tests inservices/api-server/tests/unit/test__fastapi.py
). That issue was fixed in starlette and released instarlette==0.20.2
, BUT fastapi still hasstarlette==0.19.1
which should be resolved with When a url contains colon, it makes 404 response. After I upgrade fastapi from 0.75.0 to 0.77.1. fastapi/fastapi#4892.ON HOLD-> recently released https://github.com/tiangolo/fastapi/releases/tag/0.85.0Related issue/s
How to test
services/api-server/tests/unit/test__fastapi.py
Checklist
starlette>=0.20.2
-> https://github.com/tiangolo/fastapi/releases/tag/0.85.0upgrade director?won't doHighlights on updated libraries (only updated libraries are included)
autoscaling⬆️
catalog⬆️
datcore-adapter⬆️
director-v2⬆️
dynamic-sidecar⬆️
service-library🧪
autoscaling⬆️
catalog⬆️
datcore-adapter⬆️
director-v2⬆️
dynamic-sidecar⬆️
service-library🧪
catalog⬆️
director-v2⬆️
storage⬆️
web⬆️
Legend:
Repo-wide overview of libraries