Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance: renamed travis tests to heavy load #3099

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 13, 2022

What do these changes do?

  • sorted calls in bash scripts alphabetically
  • renamed the marker "travis" (outdated) to "heavy_load"
    • one can now create a test that should not run in the CI because it is too heavy (for example a test that moves around 10 GB of data which the CI does not like too much) one can do for example:
@pytest.mark.parametrize(
    "file_size",
    [
        _file_size("10Mib"),
        _file_size("1003Mib"),
        pytest.mark.heavy_load(_file_size("7Gib")),
    ],
)

It will skip the test if the marker "not heavy_load" is set

Related issue/s

Additional Note:

  • Since there is currently an issue in Github Actions with the setup-node/setup-python actions (caching is broken), the timeout for unit tests was expended by 3 minutes.

Note: pre-requisiste to #3021

How to test

Checklist

@sanderegg sanderegg added this to the Diolkos milestone Jun 13, 2022
@sanderegg sanderegg requested a review from pcrespov as a code owner June 13, 2022 11:45
@sanderegg sanderegg self-assigned this Jun 13, 2022
@sanderegg sanderegg requested review from GitHK and odeimaiz June 13, 2022 11:46
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3099 (63f259c) into master (b2d3262) will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3099     +/-   ##
========================================
- Coverage    80.9%   80.6%   -0.3%     
========================================
  Files         706     706             
  Lines       30477   30477             
  Branches     3950    3950             
========================================
- Hits        24656   24587     -69     
- Misses       4969    5032     +63     
- Partials      852     858      +6     
Flag Coverage Δ
integrationtests 64.8% <ø> (-1.0%) ⬇️
unittests 77.1% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_director_v2/api/routes/computations.py 59.3% <0.0%> (-31.3%) ⬇️
...ector_v2/modules/db/repositories/comp_pipelines.py 83.3% <0.0%> (-11.2%) ⬇️
...r-v2/src/simcore_service_director_v2/utils/dags.py 87.6% <0.0%> (-7.7%) ⬇️
..._director_v2/modules/db/repositories/comp_tasks.py 85.8% <0.0%> (-6.7%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 73.3% <0.0%> (-3.4%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 79.4% <0.0%> (-3.0%) ⬇️
.../simcore_service_director_v2/utils/computations.py 82.8% <0.0%> (-2.9%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <0.0%> (-1.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.7% <0.0%> (-1.5%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 91.3% <0.0%> (-1.3%) ⬇️
... and 6 more

ci/github/unit-testing/api.bash Show resolved Hide resolved
@sanderegg sanderegg force-pushed the maintenance/renamed_travis_tests_to_heavy_load branch from bc794c0 to f2029f9 Compare June 13, 2022 11:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sanderegg sanderegg merged commit 90ec142 into ITISFoundation:master Jun 13, 2022
@sanderegg sanderegg deleted the maintenance/renamed_travis_tests_to_heavy_load branch June 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants