🐛 Fixes failing test in master #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3094 +/- ##
========================================
+ Coverage 79.6% 80.9% +1.3%
========================================
Files 716 716
Lines 30922 30924 +2
Branches 4035 4035
========================================
+ Hits 24618 25044 +426
+ Misses 5405 5004 -401
+ Partials 899 876 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
sanderegg
approved these changes
Jun 10, 2022
| @@ -409,6 +409,10 @@ async def _run_scheduler_task(self) -> None: | |||
| settings: DynamicServicesSchedulerSettings = ( | |||
| self.app.state.settings.DYNAMIC_SERVICES.DYNAMIC_SCHEDULER | |||
| ) | |||
| logger.debug( | |||
| "dynamic-sidecars observation interval %s", | |||
| settings.DIRECTOR_V2_DYNAMIC_SCHEDULER_INTERVAL_SECONDS, | |||
There was a problem hiding this comment.
question: is this not already printed out at the start of director-v2??
There was a problem hiding this comment.
No this one was not printed.
| @@ -500,14 +504,13 @@ async def setup_scheduler(app: FastAPI): | |||
|
|
|||
| async def shutdown_scheduler(app: FastAPI): | |||
| scheduler: DynamicSidecarsScheduler = app.state.dynamic_sidecar_scheduler | |||
| ## FIXME: somehow this does not work | |||
| # assert isinstance(scheduler, DynamicSidecarsScheduler) # nosec | |||
| assert isinstance(scheduler, DynamicSidecarsScheduler) # nosec | |||
|
|
|||
| # FIXME: PC->ANE: if not started, should it be shutdown? | |||
There was a problem hiding this comment.
maybe have a look at this FIXME too?
There was a problem hiding this comment.
I left it in there for a later review.
The action pointed out is already being handled by the function.
pcrespov
approved these changes
Jun 10, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
After an
httpxupgrade a test started failing due to timing timing/concurrency. Making sure all the pending requests finish before closing the client.Related issue/s
How to test
Checklist