Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ♻️✨ Is560/project rest models #3082

Closed

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 31, 2022

What do these changes do?

  • pydantic models for projects at the webserver rest API

Related issue/s

How to test

Checklist

  • f
  • Openapi changes? make openapi-specs, git commit ... and then make version-*)
  • Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.5% 0.5% Duplication

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #3082 (6c97c5e) into master (1d334b7) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 6c97c5e differs from pull request most recent head 982e3c3. Consider uploading reports for the commit 982e3c3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3082     +/-   ##
========================================
- Coverage    81.8%   81.7%   -0.1%     
========================================
  Files         822     724     -98     
  Lines       34915   30976   -3939     
  Branches      736    4005   +3269     
========================================
- Hits        28581   25330   -3251     
+ Misses       6148    4826   -1322     
- Partials      186     820    +634     
Flag Coverage Δ
integrationtests 66.2% <0.0%> (+6.6%) ⬆️
unittests 78.2% <0.0%> (-2.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce-integration/src/service_integration/settings.py 0.0% <0.0%> (-100.0%) ⬇️
...sidecar/src/simcore_service_dynamic_sidecar/cli.py 0.0% <0.0%> (-96.5%) ⬇️
...rvice-library/src/servicelib/aiohttp/monitoring.py 0.0% <0.0%> (-73.0%) ⬇️
...es/service-library/src/servicelib/logging_utils.py 0.0% <0.0%> (-37.3%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 66.6% <0.0%> (-28.1%) ⬇️
...erver/src/simcore_service_webserver/login/utils.py 51.6% <0.0%> (-25.9%) ⬇️
...rver/src/simcore_service_webserver/security_api.py 75.8% <0.0%> (-24.2%) ⬇️
...ver/src/simcore_service_webserver/login/storage.py 83.7% <0.0%> (-16.3%) ⬇️
.../web/server/src/simcore_service_webserver/redis.py 81.4% <0.0%> (-14.9%) ⬇️
...service_webserver/version_control_handlers_base.py 58.6% <0.0%> (-13.8%) ⬇️
... and 407 more

@pcrespov pcrespov self-assigned this Jun 1, 2022
@pcrespov pcrespov force-pushed the is560/project-rest-models branch 2 times, most recently from d085c78 to baae9a0 Compare July 7, 2022 15:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov added this to the vaporwave milestone Sep 27, 2022
@pcrespov pcrespov force-pushed the is560/project-rest-models branch from baae9a0 to 982e3c3 Compare October 14, 2022 12:43
@pcrespov pcrespov modified the milestones: vaporwave, Katherine Switzer Oct 17, 2022
@pcrespov pcrespov force-pushed the is560/project-rest-models branch 2 times, most recently from dd0d0bb to e1d0c14 Compare October 26, 2022 09:11
@pcrespov pcrespov force-pushed the is560/project-rest-models branch from e1d0c14 to 647b69a Compare November 15, 2022 10:20
@pcrespov pcrespov modified the milestones: Katherine Switzer, Athena Nov 17, 2022
@pcrespov pcrespov force-pushed the is560/project-rest-models branch from 647b69a to 37848a8 Compare December 1, 2022 09:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov closed this Feb 6, 2023
@pcrespov pcrespov deleted the is560/project-rest-models branch February 6, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant