🐛🔨 Maintenance: fixes log-level of server in boot and bumpversion commit failure #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3070 +/- ##
======================================
Coverage 80.8% 80.8%
======================================
Files 715 715
Lines 30849 30849
Branches 4024 4024
======================================
Hits 24933 24933
Misses 5053 5053
Partials 863 863
Flags with carried forward coverage won't be shown. Click here to find out more. |
pcrespov
force-pushed
the
maintenance/minor-fixes
branch
from
6989e35 to
d2d6992
Compare
pcrespov
changed the title
pcrespov
requested review from
sanderegg,
GitHK,
mguidon and
KZzizzle
as code owners
pcrespov
force-pushed
the
maintenance/minor-fixes
branch
from
d2d6992 to
a38d18b
Compare
GitHK
approved these changes
May 24, 2022
sanderegg
approved these changes
May 24, 2022
mguidon
reviewed
May 24, 2022
mguidon
approved these changes
May 24, 2022
…er changing README
pcrespov
force-pushed
the
maintenance/minor-fixes
branch
from
19e9015 to
889a78d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Two very verbose but simple fixes:
boot.shsets the same log-level to the app as to the server (i.e.uvicornorgunicorn). Up to now, they were not connected and portainer would always show INFO logs of the server regardless the log-level we set via env varsbumpversionwas failing to commit due to pre-commit-hook failing in modified README -> disabled pre-commit check on bumpversion changes.Related issue/s
Maintenance