Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance/rclone flaky test #3050

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 17, 2022

What do these changes do?

Marks packages/simcore-sdk/tests/integration/test_node_ports_v2_r_clone_.py::test_sync_local_to_s3[some funky name.txt] test as flaky

  • ♻️ renames test to convention
  • ♻️ sorts _test.in requirements and add flaky package (does not require downstream update)

@pcrespov pcrespov self-assigned this May 17, 2022
@pcrespov pcrespov requested review from GitHK and sanderegg May 17, 2022 16:14
@pcrespov pcrespov marked this pull request as ready for review May 17, 2022 16:14
@pcrespov pcrespov added this to the Croissant milestone May 17, 2022
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #3050 (3e7eb3e) into master (62c4c48) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3050     +/-   ##
========================================
- Coverage    80.5%   80.5%   -0.1%     
========================================
  Files         712     712             
  Lines       30686   30686             
  Branches     4006    4006             
========================================
- Hits        24729   24722      -7     
- Misses       5107    5112      +5     
- Partials      850     852      +2     
Flag Coverage Δ
integrationtests 66.1% <ø> (-0.1%) ⬇️
unittests 76.4% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
...imcore_service_webserver/garbage_collector_task.py 94.8% <0.0%> (-5.2%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 65.2% <0.0%> (-3.1%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 79.4% <0.0%> (-3.0%) ⬇️
.../simcore_service_catalog/services/access_rights.py 78.7% <0.0%> (-2.5%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 87.2% <0.0%> (ø)
...rector_v2/modules/comp_scheduler/base_scheduler.py 88.6% <0.0%> (+1.8%) ⬆️
...ector_v2/modules/comp_scheduler/background_task.py 91.6% <0.0%> (+8.3%) ⬆️

@pcrespov pcrespov requested a review from mguidon May 17, 2022 17:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@pcrespov pcrespov merged commit 9ce92d6 into ITISFoundation:master May 18, 2022
@pcrespov pcrespov deleted the maintenance/rclone-flaky-test branch May 18, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants