Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Maintenance: upgrade dependencies of webserver service #3038

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 11, 2022

What do these changes do?

Before adding new features in the web-server we proceed with a prune and upgrade of the dependencies:

  • ⬆️ upgrades all dependencies of webserver
  • 🗑️ replaced semantic_version by packaging.version already installed
  • 🔨 enhanced requirements/tools/check_changes.py script

Highlights on updated libraries (only updated libraries are included)

  • #packages before: 21
  • #packages after : 20
# name before after upgrade count packages
1 aio-pika 7.1.2 7.2.0 minor 1 web⬆️
2 click 8.0.4 8.1.3 minor 3 web⬆️🧪🔧
3 cryptography 36.0.2 37.0.2 MAJOR 2 web⬆️🧪
4 email-validator 1.1.3 1.2.1 minor 1 web⬆️
5 faker 13.7.0 13.11.0 minor 1 web🧪
6 hypothesis 6.46.2 6.46.3 1 web🧪
7 jinja2 3.1.1 3.1.2 1 web⬆️
8 jsondiff 1.3.1 2.0.0 MAJOR 1 web⬆️
9 orjson 3.6.7 3.6.8 1 web⬆️
10 pint 0.18 0.19.2 minor 1 web⬆️
11 prometheus-client 0.13.1 0.14.1 minor 1 web⬆️
12 pyparsing 3.0.7 3.0.9 2 web⬆️🧪
13 redis 4.2.2 4.3.1 minor 2 web⬆️🧪
14 semantic-version 2.9.0 🗑️ removed 1 web⬆️
15 setproctitle 1.2.2 1.2.3 1 web⬆️
16 sqlalchemy 1.4.32 1.4.36 2 web⬆️🧪
17 tqdm 4.63.1 4.64.0 minor 1 web⬆️
18 typing-extensions 4.1.1 4.2.0 minor 3 web⬆️🧪🔧
19 ujson 5.1.0 5.2.0 minor 1 web⬆️
20 werkzeug 2.0.3 2.1.2 minor 1 web⬆️
21 wrapt 1.14.0 1.14.1 2 web⬆️🧪

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

Related issue/s

  • maintenance

How to test

To test that all requirements are frozen:

  1. cd web/server
  2. install for production: make install-prod
  3. run recipe make pip-freeze -> freeze-base.ignore.txt and freeze-now.ignore.txt
  4. compare those two files
  5. should only differ in :
    • simcore-* libraries
    • capitalization or - vs _
    • freeze-now include pip-tools and pep517 tooling (for pip-sync)

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #3038 (8b023be) into master (1ac5803) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3038   +/-   ##
======================================
  Coverage    79.7%   79.7%           
======================================
  Files         698     698           
  Lines       29283   29283           
  Branches     3774    3774           
======================================
  Hits        23345   23345           
+ Misses       5090    5086    -4     
- Partials      848     852    +4     
Flag Coverage Δ
integrationtests 65.9% <100.0%> (+<0.1%) ⬆️
unittests 75.4% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../web/server/src/simcore_service_webserver/_meta.py 100.0% <100.0%> (ø)
...simcore_service_webserver/computation_subscribe.py 88.0% <0.0%> (-4.0%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 73.3% <0.0%> (-3.4%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.7% <0.0%> (-1.5%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-0.7%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 91.9% <0.0%> (-0.7%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.9% <0.0%> (+0.4%) ⬆️
...imcore_service_webserver/garbage_collector_core.py 70.7% <0.0%> (+0.6%) ⬆️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 91.2% <0.0%> (+1.0%) ⬆️
...ore_service_director_v2/utils/dask_client_utils.py 83.4% <0.0%> (+5.2%) ⬆️

@pcrespov pcrespov added a:webserver issue related to the webserver service dependencies t:maintenance Some planned maintenance work labels May 11, 2022
@pcrespov pcrespov self-assigned this May 11, 2022
@pcrespov pcrespov marked this pull request as ready for review May 11, 2022 17:53
@pcrespov pcrespov requested review from sanderegg and GitHK as code owners May 11, 2022 17:53
@pcrespov pcrespov requested review from mguidon and colinRawlings May 11, 2022 17:56
@pcrespov pcrespov added this to the Croissant milestone May 11, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@pcrespov pcrespov merged commit e15ccba into ITISFoundation:master May 12, 2022
@pcrespov pcrespov deleted the maintenance/webserver-upgrade branch May 12, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants