🐛 Fix storage not starting with regular https addresses #3023

GitHK · 2022-05-05T10:32:28Z

What do these changes do?

Fixes issues with storage not being able to start when configured with an S3 url not containing a port

Related issue/s

How to test

Checklist

Unit tests for the changes exist

codecov · 2022-05-05T10:33:35Z

Codecov Report

Merging #3023 (dfb6367) into master (46d91c6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master   #3023   +/-   ##
======================================
  Coverage    79.7%   79.7%           
======================================
  Files         698     698           
  Lines       29215   29215           
  Branches     3755    3755           
======================================
+ Hits        23293   23294    +1     
+ Misses       5081    5080    -1     
  Partials      841     841

Flag	Coverage Δ
integrationtests	`65.9% <ø> (+<0.1%)`	⬆️
unittests	`75.4% <100.0%> (-0.1%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
services/storage/src/simcore_service_storage/s3.py	`82.5% <100.0%> (ø)`
...ore_service_director_v2/utils/dask_client_utils.py	`78.2% <0.0%> (-5.3%)`	⬇️
.../simcore_service_catalog/db/repositories/groups.py	`70.2% <0.0%> (-2.8%)`	⬇️
.../simcore_service_catalog/services/access_rights.py	`78.7% <0.0%> (-2.5%)`	⬇️
...c/simcore_service_catalog/core/background_tasks.py	`66.3% <0.0%> (-2.2%)`	⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py	`81.5% <0.0%> (-0.5%)`	⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py	`87.1% <0.0%> (-0.5%)`	⬇️
.../director/src/simcore_service_director/producer.py	`61.9% <0.0%> (+0.2%)`	⬆️
...simcore_service_director_v2/modules/dask_client.py	`92.5% <0.0%> (+0.6%)`	⬆️
.../src/simcore_service_webserver/director_v2_core.py	`76.6% <0.0%> (+0.9%)`	⬆️
... and 5 more