🐛Separate caching director call from user dependent service listing

[sanderegg]

What do these changes do?

The caching of the list of services from the director was filtered with a user-dependent list of services available in the database. This explains the various errors in the catalog.

Related issue/s

fixes #3005

How to test

Checklist

[codecov]

Codecov Report

Merging #3020 (d851b99) into master (eec1f9e) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head d851b99 differs from pull request most recent head 0a3dc36. Consider uploading reports for the commit 0a3dc36 to get more accurate results

@@           Coverage Diff            @@
##           master   #3020     +/-   ##
========================================
- Coverage    79.7%   79.7%   -0.1%     
========================================
  Files         693     693             
  Lines       29052   29049      -3     
  Branches     3745    3745             
========================================
- Hits        23158   23154      -4     
  Misses       5062    5062             
- Partials      832     833      +1     

Flag	Coverage Δ
integrationtests	65.8% <0.0%> (+<0.1%)	⬆️
unittests	75.5% <0.0%> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/simcore_service_catalog/core/background_tasks.py	66.3% <0.0%> (-2.2%)	⬇️
...imcore_service_webserver/garbage_collector_core.py	68.2% <0.0%> (-1.3%)	⬇️
.../director/src/simcore_service_director/producer.py	61.6% <0.0%> (-0.9%)	⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py	87.1% <0.0%> (-0.5%)	⬇️
...2/src/simcore_service_director_v2/core/settings.py	98.7% <0.0%> (-0.1%)	⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py	81.9% <0.0%> (ø)
...es/dynamic_sidecar/docker_service_specs/sidecar.py	78.5% <0.0%> (ø)
..._director_v2/modules/dynamic_sidecar/client_api.py	78.4% <0.0%> (+1.0%)	⬆️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py	93.8% <0.0%> (+1.6%)	⬆️
.../simcore_service_catalog/services/access_rights.py	81.2% <0.0%> (+2.5%)	⬆️
... and 1 more

[KZzizzle]

thanks for the notice! (and congrats on sonarcloud)

[mrnicegyu11]

Thanks a lot!
Please consider making DIRECTOR_CACHING_TTL adjustable via env-vars, and if DIRECTOR_CACHING_TTL=0 maybe caching could be disabled? Just a suggestion, the former would be easier I guess :)

thanks for taking care of this :)

[GitHK]

👍

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication