Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ♻️ Is560/clone projects #2974

Closed
wants to merge 19 commits into from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 8, 2022

What do these changes do?

Related issue/s

How to test

Checklist

@pcrespov pcrespov self-assigned this Apr 8, 2022
@pcrespov pcrespov added this to the a-mile-stone milestone Apr 8, 2022
@pcrespov pcrespov force-pushed the is560/clone-projects branch from 1499bb8 to 187791c Compare April 9, 2022 23:32
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #2974 (79319d0) into master (775690f) will increase coverage by 0.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2974      +/-   ##
=========================================
+ Coverage    80.5%   81.0%    +0.5%     
=========================================
  Files         709     370     -339     
  Lines       30661   15556   -15105     
  Branches     4000    2224    -1776     
=========================================
- Hits        24685   12613   -12072     
+ Misses       5125    2514    -2611     
+ Partials      851     429     -422     
Flag Coverage Δ
integrationtests 78.6% <ø> (+12.5%) ⬆️
unittests 76.2% <100.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/models-library/src/models_library/basic_types.py 100.0% <100.0%> (ø)
...rary/src/servicelib/aiohttp/requests_validation.py 100.0% <100.0%> (ø)
..._director_v2/modules/dynamic_sidecar/docker_api.py 86.8% <0.0%> (-1.3%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 90.6% <0.0%> (-1.1%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.4% <0.0%> (-0.5%) ⬇️
...mcore_service_webserver/projects/project_models.py
...simcore_service_webserver/projects/projects_api.py
...re_service_webserver/projects/projects_handlers.py
...rvice_webserver/projects/projects_handlers_crud.py
.../web/server/src/simcore_service_webserver/utils.py
... and 335 more

@pcrespov pcrespov force-pushed the is560/clone-projects branch 2 times, most recently from 2ab46c9 to ba677b5 Compare April 21, 2022 12:44
@pcrespov pcrespov modified the milestones: Macarons, Croissant May 11, 2022
@pcrespov pcrespov force-pushed the is560/clone-projects branch from ba677b5 to 79319d0 Compare May 16, 2022 13:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@pcrespov pcrespov changed the title ♻️ Is560/clone projects WIP: ♻️ Is560/clone projects Jun 3, 2022
@pcrespov
Copy link
Member Author

Split in multiple PRs

@pcrespov pcrespov closed this Jun 30, 2022
@pcrespov pcrespov deleted the is560/clone-projects branch June 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant