Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixes concurrency issue with directory-watcher #2932

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 31, 2022

What do these changes do?

Directory watcher is now disabled when starting the dynamic-sidecar.

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist
  • Runs in the swarm

@GitHK GitHK self-assigned this Mar 31, 2022
@GitHK GitHK requested review from mguidon, sanderegg and pcrespov March 31, 2022 10:19
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #2932 (1777fb5) into master (e26f5c6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2932   +/-   ##
======================================
  Coverage    79.5%   79.5%           
======================================
  Files         677     677           
  Lines       28230   28231    +1     
  Branches     3643    3643           
======================================
+ Hits        22466   22467    +1     
  Misses       4999    4999           
  Partials      765     765           
Flag Coverage Δ
integrationtests 65.7% <ø> (+0.1%) ⬆️
unittests 75.0% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ervice_dynamic_sidecar/api/containers_extension.py 89.6% <100.0%> (ø)
...rvice_dynamic_sidecar/modules/directory_watcher.py 92.3% <100.0%> (+<0.1%) ⬆️
...simcore_service_webserver/projects/project_lock.py 94.7% <0.0%> (-5.3%) ⬇️
.../simcore_service_catalog/db/repositories/groups.py 70.2% <0.0%> (-2.8%) ⬇️
...c/simcore_service_catalog/core/background_tasks.py 66.3% <0.0%> (-2.2%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.4% <0.0%> (-1.6%) ⬇️
...ervices/storage/src/simcore_service_storage/dsm.py 73.4% <0.0%> (-0.7%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 87.2% <0.0%> (-0.5%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 70.5% <0.0%> (ø)
.../director/src/simcore_service_director/producer.py 62.3% <0.0%> (+0.6%) ⬆️
... and 2 more

@GitHK GitHK added bug buggy, it does not work as expected a:dynamic-sidecar dynamic-sidecar service changelog:🐛bugfix labels Mar 31, 2022
@GitHK GitHK merged commit f070cbc into ITISFoundation:master Mar 31, 2022
@GitHK GitHK deleted the fix-directory-watcher-start-disabled branch March 31, 2022 13:25
@sanderegg sanderegg added this to the E.Shackleton milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants