-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrades api-server requirements #2827
Merged
pcrespov
merged 4 commits into
ITISFoundation:master
from
pcrespov:maintenance/api-server-reqs
Mar 2, 2022
Merged
⬆️ Upgrades api-server requirements #2827
pcrespov
merged 4 commits into
ITISFoundation:master
from
pcrespov:maintenance/api-server-reqs
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2827 +/- ##
========================================
- Coverage 81.7% 79.1% -2.7%
========================================
Files 419 672 +253
Lines 20280 27468 +7188
Branches 2202 3205 +1003
========================================
+ Hits 16577 21736 +5159
- Misses 3062 4986 +1924
- Partials 641 746 +105
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a6872a7
to
ad51c69
Compare
2 tasks
ad51c69
to
eb9b4aa
Compare
GitHK
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
odeimaiz
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In preparation for new features, we upgrade api-server requirements.
base requirements
tests requirements
Related issue/s
How to test
cd services/api-server make install-dev make test-dev
make build cd tests/public-api make install-ci make test-dev
_base.txt
is indeed the dependencies installed in production. This is done by comparing these two files manually (for the moment)Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)cd packages/postgres-database
,make setup-commit
,sc-pg review -m "my changes"