-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔒️ Adds codeql-analysis cron job #2826
🔒️ Adds codeql-analysis cron job #2826
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2826 +/- ##
========================================
+ Coverage 76.0% 79.2% +3.2%
========================================
Files 675 675
Lines 27642 27640 -2
Branches 3221 3221
========================================
+ Hits 21017 21912 +895
+ Misses 5935 4979 -956
- Partials 690 749 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d261ad4
to
f901155
Compare
f901155
to
745f8ec
Compare
...r-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/sidecar.py
Show resolved
Hide resolved
@@ -0,0 +1,26 @@ | |||
name: "ospac-simcore CodeQL config" | |||
|
|||
disable-default-queries: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what are we scanning for by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the links above RT... :-) ... but basically thinks like plotting sensitive info (e.g. he was able to trace in the code and detect that a password was printed in the logs ... was quite impressive BTW)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice tool!
What do these changes do?
SecretStr
in pydantic models for objects that are loggedMore details:
To see some of the job runs, check the "Actions" tab and select CodeQL workflow
Related issue/s
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)cd packages/postgres-database
,make setup-commit
,sc-pg review -m "my changes"