-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 adds exception rules for legacy services (⚠️ devops) #2813
Merged
pcrespov
merged 4 commits into
ITISFoundation:master
from
pcrespov:fix/override-for-service-legacy
Feb 9, 2022
Merged
🐛 adds exception rules for legacy services (⚠️ devops) #2813
pcrespov
merged 4 commits into
ITISFoundation:master
from
pcrespov:fix/override-for-service-legacy
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2813 +/- ##
======================================
Coverage 78.9% 78.9%
======================================
Files 670 670
Lines 27230 27236 +6
Branches 2677 2678 +1
======================================
+ Hits 21486 21492 +6
- Misses 4988 4989 +1
+ Partials 756 755 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
mguidon
approved these changes
Feb 9, 2022
mrnicegyu11
approved these changes
Feb 9, 2022
odeimaiz
approved these changes
Feb 9, 2022
8981fe9
to
c390b3c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This fix follows up from #2803
After observing master, we noticed that the GC was failing to stop old services because they would not save their state. It happens that some old services do not add that functionality and threfore the new rule introduced in #2803 needs to introduce some exceptions to support this legacy.
NOTE1: that all this functionality will be taken over by the new side-car.⚠️ devops): #2803 must not be released alone but together with this PR. Otherwise, the GC will fail to close old services (mostly used in the e2e) and will collapse resources in the cluster (as observed in master)
NOTE2 (
Related issue/s
#2803
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)cd packages/postgres-database
,make setup-commit
,sc-pg review -m "my changes"