Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes wrong signature and adds tests #2812

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 9, 2022

What do these changes do?

Fixes wrong signature in project_utils (somehow was not caught by our linter! Follow up in #2811 )
This could have been prevented if I would have not missed (forgot) the tests in PR #2797

Related issue/s

How to test

Checklist

  • Openapi changes? make openapi-specs, git commit ... and then make version-*)
  • Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov self-assigned this Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2812 (546e373) into master (306355e) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2812     +/-   ##
========================================
+ Coverage    78.8%   78.9%   +0.1%     
========================================
  Files         670     670             
  Lines       27230   27230             
  Branches     2677    2677             
========================================
+ Hits        21469   21508     +39     
+ Misses       5002    4967     -35     
+ Partials      759     755      -4     
Flag Coverage Δ
integrationtests 65.9% <50.0%> (+<0.1%) ⬆️
unittests 74.5% <100.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mcore_service_webserver/projects/projects_utils.py 80.7% <100.0%> (+8.1%) ⬆️
.../director/src/simcore_service_director/producer.py 62.4% <0.0%> (+0.4%) ⬆️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 86.4% <0.0%> (+0.5%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 73.5% <0.0%> (+0.8%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 91.7% <0.0%> (+1.0%) ⬆️
...simcore_service_director_v2/modules/dask_client.py 83.2% <0.0%> (+1.2%) ⬆️
...simcore_service_webserver/projects/project_lock.py 100.0% <0.0%> (+5.2%) ⬆️
...rvice-library/src/servicelib/common_aiopg_utils.py 97.0% <0.0%> (+8.8%) ⬆️
...imcore_service_catalog/db/repositories/projects.py 54.1% <0.0%> (+12.5%) ⬆️
... and 1 more

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov added this to the R.Schumann milestone Feb 9, 2022
@pcrespov pcrespov merged commit 89c2673 into ITISFoundation:master Feb 9, 2022
@pcrespov pcrespov deleted the fix/project-utils-typo branch February 9, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants