-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Search filters #2804
Fix: Search filters #2804
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
======================================
Coverage 78.8% 78.9%
======================================
Files 670 670
Lines 27200 27200
Branches 2669 2669
======================================
+ Hits 21454 21461 +7
+ Misses 4990 4985 -5
+ Partials 756 754 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magical!
What do these changes do?
Issue: Study/Template/Service cards were interacting with the search filters that didn't belong to their tab. This PR fixes that bug:
![filtering](https://user-images.githubusercontent.com/33152403/152994219-cff70f95-6337-4e2a-b911-d7671ecf54eb.gif)
How to test
Checklist