Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ upgrade redis to 6.2.6, added persistency ⚠️ devops #2793

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Feb 4, 2022

What do these changes do?

⚠️ devops: You need to ensure that the redis database ALWAYS end up on the node with the docker volume necessary for REDIS to regenerate its data. We should maybe also check redundancy (several mirrored redis databases).

bonus:

  • clean up docker-compose-ops.yml of deprecated features in filestash and onlyoffice services.

Related issue/s

How to test

Checklist

@sanderegg sanderegg self-assigned this Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #2793 (ab55ed2) into master (d7b614e) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2793   +/-   ##
======================================
  Coverage    78.7%   78.8%           
======================================
  Files         674     674           
  Lines       27352   27352           
  Branches     3182    3182           
======================================
+ Hits        21546   21560   +14     
+ Misses       5041    5030   -11     
+ Partials      765     762    -3     
Flag Coverage Δ
integrationtests 65.7% <ø> (-0.1%) ⬇️
unittests 74.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 93.7% <0.0%> (-1.2%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 81.9% <0.0%> (-0.7%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 85.8% <0.0%> (-0.6%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-0.5%) ⬇️
...car/src/simcore_service_dask_sidecar/dask_utils.py 90.7% <0.0%> (+1.0%) ⬆️
.../server/src/simcore_service_webserver/users_api.py 94.4% <0.0%> (+2.4%) ⬆️
...simcore_service_webserver/projects/project_lock.py 100.0% <0.0%> (+5.2%) ⬆️
...imcore_service_catalog/db/repositories/projects.py 54.1% <0.0%> (+12.5%) ⬆️
...c/simcore_service_catalog/core/background_tasks.py 80.8% <0.0%> (+12.7%) ⬆️

@pcrespov pcrespov added this to the Rudolph+1 milestone Feb 4, 2022
@sanderegg sanderegg changed the title WIP: ⬆️ upgrade to redis 6.2.6 ⬆️ upgrade redis to 6.2.6, added persistency Feb 20, 2022
@sanderegg sanderegg changed the title ⬆️ upgrade redis to 6.2.6, added persistency ⬆️ upgrade redis to 6.2.6, added persistency ⚠️ devops Feb 20, 2022
@sanderegg sanderegg marked this pull request as ready for review February 20, 2022 19:01
@sanderegg sanderegg force-pushed the enhancement/add_redis_persistence branch from 6a73175 to ab55ed2 Compare February 20, 2022 19:01
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@@ -20,8 +20,7 @@ services:
- traefik.http.services.${SWARM_STACK_NAME}_api-server.loadbalancer.healthcheck.path=/
- traefik.http.services.${SWARM_STACK_NAME}_api-server.loadbalancer.healthcheck.interval=2000ms
- traefik.http.services.${SWARM_STACK_NAME}_api-server.loadbalancer.healthcheck.timeout=1000ms
- traefik.http.routers.${SWARM_STACK_NAME}_api-server.rule=hostregexp(`{host:.+}`)
&& (Path(`/`, `/v0`) || PathPrefix(`/v0/`))
- traefik.http.routers.${SWARM_STACK_NAME}_api-server.rule=hostregexp(`{host:.+}`) && (Path(`/`, `/v0`) || PathPrefix(`/v0/`))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha .. i thought lines those were intentionally folded and undid them in my last PR :-)

@sanderegg sanderegg merged commit 4c35a9e into ITISFoundation:master Feb 21, 2022
@sanderegg sanderegg deleted the enhancement/add_redis_persistence branch February 21, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants