Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ adds constraint to pip~=21.3 util pip-tools issue resolved #2772

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 31, 2022

Prevents pip to upgrade to version 22 until jazzband/pip-tools#1558 is resolved

Dockerfile are all synced to pip~=21.3 (See tests/environment-setup/test_used_python.py)

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2772 (243aaf5) into master (cf7791f) will decrease coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2772     +/-   ##
========================================
- Coverage    78.8%   77.9%   -0.9%     
========================================
  Files         680     680             
  Lines       27101   27101             
  Branches     2633    2633             
========================================
- Hits        21362   21129    -233     
- Misses       4995    5244    +249     
+ Partials      744     728     -16     
Flag Coverage Δ
integrationtests 64.4% <ø> (-1.4%) ⬇️
unittests 74.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re-sdk/src/simcore_sdk/node_ports/serialization.py 25.0% <0.0%> (-57.4%) ⬇️
...imcore-sdk/src/simcore_sdk/node_ports/nodeports.py 29.1% <0.0%> (-50.0%) ⬇️
...k/src/simcore_sdk/node_ports_common/filemanager.py 36.3% <0.0%> (-44.7%) ⬇️
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py 43.0% <0.0%> (-43.1%) ⬇️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 66.4% <0.0%> (-28.0%) ⬇️
...sdk/src/simcore_sdk/node_ports/_data_items_list.py 55.2% <0.0%> (-10.6%) ⬇️
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
...k/src/simcore_sdk/node_ports/_schema_items_list.py 91.3% <0.0%> (-8.7%) ⬇️
...re_sdk/node_ports_common/client_session_manager.py 92.3% <0.0%> (-7.7%) ⬇️
.../simcore_sdk/node_ports_common/data_items_utils.py 92.5% <0.0%> (-7.5%) ⬇️
... and 9 more

@pcrespov pcrespov requested a review from sanderegg January 31, 2022 10:05
@pcrespov pcrespov self-assigned this Jan 31, 2022
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep... that is also what I did in another repo.

@pcrespov pcrespov merged commit 2c85b73 into ITISFoundation:master Jan 31, 2022
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the tip

@pcrespov pcrespov deleted the maintenance/freeze-pip-until-piptools-fixed branch January 31, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants