Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 Maintenance/webserver requirements #2741

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 13, 2022

What do these changes do?

  • fixes web/server/requirements : removes packages.* files and old constraints.
  • Add extra dependency tools (pipreqs and pipreqtree to assist resolving conflicts and analyzing dependencies)

Related issue/s

How to test

Check that the requirements _base.txt are the libraries that actually get installed in production:

$ make devenv
$ source .venv/bin/activate
$ cd services/web/server

$ make install-prod

$ make pip-freeze

$  diff -i freeze-base.ignore.txt freeze-now.ignore.txt
32c32
< importlib-resources==5.4.0 ; python_version < "3.9"
---
> importlib-resources==5.4.0
50a51,52
> pep517==0.12.0
> pip-tools==6.4.0
62a65,69
> simcore-models-library @ file:///home/crespo/devp/osparc-simcore/packages/models-library
> simcore-postgres-database @ file:///home/crespo/devp/osparc-simcore/packages/postgres-database
> simcore-service-library @ file:///home/crespo/devp/osparc-simcore/packages/service-library
> simcore-service-webserver @ file:///home/crespo/devp/osparc-simcore/services/web/server
> simcore-settings-library @ file:///home/crespo/devp/osparc-simcore/packages/settings-library
66a74
> tomli==1.2.3
76d83
< 

Notice that the differences are tools (i.e. pip-tools etc) and osparc-simcore packages (which are not in _base.py)

Checklist

@pcrespov pcrespov self-assigned this Jan 13, 2022
@pcrespov pcrespov requested review from GitHK and sanderegg and removed request for GitHK January 13, 2022 22:29
@pcrespov pcrespov added this to the Rudolph milestone Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #2741 (79273f2) into master (c3f6073) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2741     +/-   ##
========================================
- Coverage    78.3%   78.2%   -0.1%     
========================================
  Files         677     677             
  Lines       27011   27011             
  Branches     2617    2617             
========================================
- Hits        21157   21149      -8     
- Misses       5147    5151      +4     
- Partials      707     711      +4     
Flag Coverage Δ
integrationtests 65.6% <ø> (-0.1%) ⬇️
unittests 74.1% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py 67.5% <0.0%> (-1.3%) ⬇️
...car/src/simcore_service_dask_sidecar/dask_utils.py 90.7% <0.0%> (-1.1%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 72.7% <0.0%> (-0.9%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 92.9% <0.0%> (-0.8%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 86.4% <0.0%> (+0.5%) ⬆️

@pcrespov pcrespov changed the title ⬆️ Maintenance/fixes webserver requirements 📌 Maintenance/fixes webserver requirements Jan 13, 2022
@pcrespov pcrespov changed the title 📌 Maintenance/fixes webserver requirements 📌 Maintenance/webserver requirements Jan 13, 2022
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Jan 13, 2022
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@pcrespov pcrespov merged commit 735f57c into ITISFoundation:master Jan 14, 2022
@pcrespov pcrespov deleted the maintenance/fix-web-server-requirements branch January 14, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants