-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance/new settings (2nd round) #2739
Merged
pcrespov
merged 33 commits into
ITISFoundation:master
from
pcrespov:maintenance/new-settings-2
Jan 14, 2022
Merged
♻️ Maintenance/new settings (2nd round) #2739
pcrespov
merged 33 commits into
ITISFoundation:master
from
pcrespov:maintenance/new-settings-2
Jan 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2739 +/- ##
========================================
+ Coverage 78.0% 78.3% +0.2%
========================================
Files 652 677 +25
Lines 26963 27011 +48
Branches 2617 2617
========================================
+ Hits 21051 21160 +109
+ Misses 5197 5144 -53
+ Partials 715 707 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
added
a:webserver
issue related to the webserver service
t:maintenance
Some planned maintenance work
labels
Jan 13, 2022
pcrespov
force-pushed
the
maintenance/new-settings-2
branch
from
January 13, 2022 19:05
75768ba
to
616ad26
Compare
pcrespov
requested review from
sanderegg,
GitHK,
colinRawlings,
mguidon,
mrnicegyu11 and
Surfict
January 13, 2022 19:08
sanderegg
approved these changes
Jan 13, 2022
GitHK
approved these changes
Jan 14, 2022
9 tasks
2 tasks
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is the second of a series of PR that will progressively introduce the new-settings (i.e. move from
trafaret
tosettings_library
) in the entire repo.In previous PR #2736 we mainly extended the
settings-library
with new settings classes and utils.Instead, this PR will focus on replacing
trafaret
from theweb-server
. There are over 20 plugins affected by the configuration so the goal of the PR is only to isolate dependencies without breaking the app.The
trafaret
-based configuration of thewebserver
is based on the composition of schemas for each plugin, typically individually defined in*_config.py
, into a single application schema inapplication_config
. In order to isolate the dependences, we will split each configuration module into two:*_schema
and*settings
, such that*_schema
: keeps trafaret's schema only. This waytrafaret
import is isolated here.*config.py
: keeps constants and helper functions to access config section stored in app.*settings
: placeholder for future service-settings library based settings (some already contain some pydantic settings).Therefore, after this refactoring every plugin will look either
Next PR in the series will include the
settings-library
in thewebserver
and create settings for each of the library in the*settings.py
module.NOTE: @mrnicegyu11 , @Surfict : in the next rounds, the env vars to configure osparc-simcore might be affected so I will start adding you as reviewers.
Related issue/s
How to test
all webserver tests affected